Skip to content

hifi conv1d fixes (#18626)#18626

Open
rezaasjd wants to merge 1 commit intopytorch:mainfrom
rezaasjd:export-D98941393
Open

hifi conv1d fixes (#18626)#18626
rezaasjd wants to merge 1 commit intopytorch:mainfrom
rezaasjd:export-D98941393

Conversation

@rezaasjd
Copy link
Copy Markdown
Contributor

@rezaasjd rezaasjd commented Mar 31, 2026

Summary:

Fixes the dilation, stride and padding 0 indexing instead of last element.

Reviewed By: mcremon-meta

Differential Revision: D98941393

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 31, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18626

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 415be0e with merge base b24535b (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Mar 31, 2026

@rezaasjd has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98941393.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title hifi conv1d fixes hifi conv1d fixes (#18626) Apr 1, 2026
rezaasjd pushed a commit to rezaasjd/executorch that referenced this pull request Apr 1, 2026
Summary:

Fixes the dilation, stride and padding 0 indexing instead of last element.

Reviewed By: mcremon-meta

Differential Revision: D98941393
Summary:

Fixes the dilation, stride and padding 0 indexing instead of last element.

Reviewed By: mcremon-meta

Differential Revision: D98941393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants