Skip to content

Lluo/executorch 2.12 cherry pick#4238

Draft
lanluo-nvidia wants to merge 3 commits intorelease/2.12from
lluo/executorch_2.12_cherry_pick
Draft

Lluo/executorch 2.12 cherry pick#4238
lanluo-nvidia wants to merge 3 commits intorelease/2.12from
lluo/executorch_2.12_cherry_pick

Conversation

@lanluo-nvidia
Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla Bot added the cla signed label May 6, 2026
@github-actions github-actions Bot added component: tests Issues re: Tests component: core Issues re: The core compiler component: build system Issues re: Build system component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels May 6, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/runtime.h b/tmp/changes.txt
index a9dad3f..59e861f 100644
--- a/home/runner/work/TensorRT/TensorRT/core/runtime/runtime.h
+++ b/tmp/changes.txt
@@ -45,21 +45,20 @@ typedef enum {
} SerializedInfoIndex;

inline constexpr std::array<const char*, SERIALIZATION_LEN> kSerializedInfoIndexNames = {{
-  "ABI_TARGET_IDX",
-  "NAME_IDX",
-  "DEVICE_IDX",
-  "ENGINE_IDX",
-  "INPUT_BINDING_NAMES_IDX",
-  "OUTPUT_BINDING_NAMES_IDX",
-  "HW_COMPATIBLE_IDX",
-  "SERIALIZED_METADATA_IDX",
-  "TARGET_PLATFORM_IDX",
-  "REQUIRES_OUTPUT_ALLOCATOR_IDX",
-  "RESOURCE_ALLOCATION_STRATEGY_IDX",
-  "REQUIRES_NATIVE_MULTIDEVICE_IDX",
+    "ABI_TARGET_IDX",
+    "NAME_IDX",
+    "DEVICE_IDX",
+    "ENGINE_IDX",
+    "INPUT_BINDING_NAMES_IDX",
+    "OUTPUT_BINDING_NAMES_IDX",
+    "HW_COMPATIBLE_IDX",
+    "SERIALIZED_METADATA_IDX",
+    "TARGET_PLATFORM_IDX",
+    "REQUIRES_OUTPUT_ALLOCATOR_IDX",
+    "RESOURCE_ALLOCATION_STRATEGY_IDX",
+    "REQUIRES_NATIVE_MULTIDEVICE_IDX",
}};

-
std::string base64_encode(const std::string& in);
std::string base64_decode(const std::string& in);
std::string serialize_bindings(const std::vector<std::string>& bindings);
ERROR: Some files do not conform to style guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant