Include 2 more files in the sdist: CREDITS & typeshed/stdlib/_typeshed/README.md#21131
Merged
JukkaL merged 1 commit intopython:masterfrom Apr 1, 2026
Merged
Include 2 more files in the sdist: CREDITS & typeshed/stdlib/_typeshed/README.md#21131JukkaL merged 1 commit intopython:masterfrom
JukkaL merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Apr 1, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
CREDITS is probably way out of date, but it seems fine to include it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not required for anything, but it seems nice.
CREDITS was excluded back in 2020, but it seems polite to include it in the sdists #9592 / f5f5485
With this PR, CREDITS won't be part of the wheel, but
typeshed/stdlib/_typeshed/README.mdwill; let me know if I should exclude it from the wheel