fix: use "constraints and a bound" in TypeVar error message#21126
Open
nuglifeleoji wants to merge 1 commit intopython:masterfrom
Open
fix: use "constraints and a bound" in TypeVar error message#21126nuglifeleoji wants to merge 1 commit intopython:masterfrom
nuglifeleoji wants to merge 1 commit intopython:masterfrom
Conversation
PEP 484 uses "constraints" for the positional arguments of TypeVar
(e.g. TypeVar("T", int, str)) and "bound" for the keyword argument.
The existing message "cannot have both values and an upper bound" used
neither term correctly. Updated to:
TypeVar cannot have both constraints and a bound
Closes python#20973
Made-with: Cursor
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20973.
PEP 484 uses constraints for the positional type arguments of
TypeVar(e.g.
TypeVar("T", int, str)) and bound for thebound=keyword.The existing error message used neither term correctly:
Updated to the standard PEP 484 terminology:
Changed
mypy/semanal.pyand the matching test fixture intest-data/unit/semanal-errors.test.Made with Cursor