Handle broken repr in tracing#666
Open
ShipItAndPray wants to merge 1 commit into
Open
Conversation
RonnyPfannschmidt
approved these changes
May 17, 2026
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
this is in part ad odds with switching to repr in another pr
also as far as i understood there is a general understanding that str/repr should never fail for object that completed their ctor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__repr__/__str__Testing
uv run --python 3.12 pytest testing/test_pluginmanager.py -k broken_repr -quv run --python 3.12 pytest testing/test_pluginmanager.py -qCloses #424.