fix: createmeta issuetypes endpoint incorrectly blocked on Jira Cloud#2416
Open
star7js wants to merge 3 commits intopycontribs:mainfrom
Open
fix: createmeta issuetypes endpoint incorrectly blocked on Jira Cloud#2416star7js wants to merge 3 commits intopycontribs:mainfrom
star7js wants to merge 3 commits intopycontribs:mainfrom
Conversation
The _check_createmeta_issuetypes() guard rejected Cloud deployments entirely, but the Jira Cloud REST API does support this endpoint. The check should only block old Server/DC versions (< 8.4.0) where the endpoint doesn't exist. Changed condition from `self._is_cloud or version < (8,4,0)` to `not self._is_cloud and version < (8,4,0)` so Cloud is always allowed and only old Server versions are blocked. Fixes pycontribs#2353
for more information, see https://pre-commit.ci
star7js
changed the title
Author
|
Hi maintainers — CI is failing because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_createmeta_issuetypes()was blocking Jira Cloud deployments entirely withself._is_cloud or version < (8,4,0)not self._is_cloud and version < (8,4,0)— Cloud always passes, only old Server/DC (< 8.4.0) is blockedcreatemeta_issuetypes,createmeta_fieldtypes,project_issue_types, andproject_issue_fieldsCloses #2353