fix: don’t forward empty JSON bodies on GET (prevents Jira 403)#2388
Open
traylenator wants to merge 1 commit intopycontribs:mainfrom
Open
fix: don’t forward empty JSON bodies on GET (prevents Jira 403)#2388traylenator wants to merge 1 commit intopycontribs:mainfrom
traylenator wants to merge 1 commit intopycontribs:mainfrom
Conversation
traylenator
changed the title
Non-empty dict → keep existing behavior and send json.dumps(data). Empty dict → remove data from prepared_kwargs so no body is sent. While I understand this is needed I do not understand why the tests ever passed. * Fixes pycontribs#2362
traylenator
force-pushed
the
emptydict
branch
from
dc159c3 to
12bcdad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I understand this is needed I do not understand why the tests ever passed.
test_empty_dict_body_not_forwardedfailure #2362