Open
Conversation
The iframe automatically scrolled to 0 when CSS `display: none` is set, so we had several workarounds. Hide it instead.
This was very complicated, particularly between versions and tabs and windows, for something that offers only a minor convenience. This also makes it simpler to navigate to a particular page interactively by just setting the iframe URL, which is useful for interactive help from the block editor.
This was an undocumented feature that gets in the way of other shortcuts, and doesn't extend well to the sideview being used for other things in future commits.
Everything is visually unchanged. This just moves the button logic to the app, since it doesn't conceptually belong to the editor component. It controls things such as docs which has nothing to do with the editor. This way we don't have to pass states as props around when we add more buttons later.
Member
Author
|
Added a few more commits to gear up for actual changes in the next pull request. This PR is still just refactoring to simplify the documentation view. All buttons are still in the same place. User visible changes:
|
laurensvalk
changed the title
Having this persist across sessions is not necessary and a bit overly complicated when we add more sideview states such as camera (which should not stay on by default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iframe automatically scrolled to 0 when CSS
display: noneis set, so we had several workarounds to keep track of scrolling.We can keep it in the DOM and hide it instead. This lets us get rid of the workarounds, but keep the position if you open the docs again.
On a related note, I wonder if we really need the active page to persist across a full reload with
app/hooks.ts.Using session storage, mirroring to local storage, and then manage outdated links all seems relatively complicated for something that isn't necessarily practical. The next day, I'd personally rather start from the home page. It also makes things a bit more complicated when navigating to a particular page from an interaction: pybricks/support#1515
Feel free to 👍 or 👎 this suggestion @dlech, otherwise I'd be happy to submit this in the next one.