Skip to content

Switch to @pulsar-edit/whats-my-line…#46

Merged
DeeDeeG merged 11 commits intomasterfrom
update-dependencies
Mar 31, 2026
Merged

Switch to @pulsar-edit/whats-my-line…#46
DeeDeeG merged 11 commits intomasterfrom
update-dependencies

Conversation

@savetheclocktower
Copy link
Copy Markdown

@savetheclocktower savetheclocktower commented Dec 18, 2025

…and fix other dependency issues.

This is a draft PR (for now) aimed at getting CI into better shape.

@savetheclocktower
Copy link
Copy Markdown
Author

savetheclocktower commented Dec 19, 2025

This is now blocked on ppm#162 and will be until that gets landed and into a rolling release of Pulsar.

@savetheclocktower savetheclocktower mentioned this pull request Dec 20, 2025
Merged
@DeeDeeG DeeDeeG mentioned this pull request Mar 30, 2026
Open
@DeeDeeG
Copy link
Copy Markdown
Member

DeeDeeG commented Mar 30, 2026

This is now blocked on pulsar-edit/ppm#162 and will be until that gets landed and into a rolling release of Pulsar.

Landed and in Rolling!

I'm looking into getting the actual github package repo up to speed compared to the non-master branch of this package + Yarn resolutions used in core, so if there is any chance of package tests passing for this package at core repo, this will at least get us closer...

@DeeDeeG DeeDeeG force-pushed the update-dependencies branch from f047f88 to 7d4a3a5 Compare March 30, 2026 23:06
DeeDeeG added 3 commits March 30, 2026 19:37
@DeeDeeG
Merge remote-tracking branch 'pulsar/master' into update-dependencies
133219b
@DeeDeeG
CI: Update discontinued windows-2019 image to windows-2022
acccd7f
@DeeDeeG
CI: Use sudo to install deb package deps on Linux
4c207c2 
We're not in Docker anymore!
(Unlike the Linux bin building job at core repo)
So, sudo is needed here for apt-get install to work.
@savetheclocktower
Copy link
Copy Markdown
Author

savetheclocktower commented Mar 30, 2026

The WorkerManager failures are expected; those specs are largely obsolete now, since we're bypassing most of the over-engineered work that WorkerManager does.

The rest I'm not sure about at first glance.

@DeeDeeG
Copy link
Copy Markdown
Member

DeeDeeG commented Mar 30, 2026 •
edited
Loading

I took some liberties to push a merge with new master content I landed moments ago (to resolve merge conflicts to make this PR landable) and added two potential CI fixes...

If those don't work and/or you prefer my pushes backed out, I am happy to go along with PR author wishes.

And also, getting CI actually passing might be too lofty a goal, and just the rest can be merged, even if CI is not passing??

@savetheclocktower
Copy link
Copy Markdown
Author

savetheclocktower commented Mar 30, 2026

I'm happy to accept the changes even if they don't get us to a fully passing CI suite right away. We can get there incrementally!

@DeeDeeG
Copy link
Copy Markdown
Member

DeeDeeG commented Mar 31, 2026 •
edited
Loading

@confused-Techie is it okay to merge this one, despite CI failing? Since at least it gets us to a state that's close to what we have in core repo of github package...

I might also tidy up this branch by taking out the "merge master to here" and manually land this PR by CLI to resolve the merge conflicts that way, if folks don't mind...

@confused-Techie
Copy link
Copy Markdown
Member

confused-Techie commented Mar 31, 2026

Yeah good point, @DeeDeeG lets just go ahead and merge this one!

@DeeDeeG DeeDeeG merged commit 9e82e93 into master Mar 31, 2026
0 of 4 checks passed
@savetheclocktower savetheclocktower deleted the update-dependencies branch March 31, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savetheclocktower @DeeDeeG @confused-Techie