Skip to content

Port the RFC SILK output resampler #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zshang-oai merged 2 commits into from
Apr 8, 2026

Address resampler review feedback

50484c7
Select commit
Loading
Failed to load commit list.
Merged

Port the RFC SILK output resampler #93

Address resampler review feedback
50484c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 6, 2026 in 0s

80.46% (+1.44%) compared to 914b0f4

View this Pull Request on Codecov

80.46% (+1.44%) compared to 914b0f4

Details

Codecov Report

❌ Patch coverage is 83.33333% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.46%. Comparing base (914b0f4) to head (50484c7).

Files with missing lines Patch % Lines
internal/resample/silk/resampler.go 79.56% 26 Missing and 2 partials ⚠️
internal/resample/silk/down_fir.go 76.04% 23 Missing ⚠️
decoder.go 84.37% 12 Missing and 8 partials ⚠️
internal/resample/silk/fixed.go 71.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   79.02%   80.46%   +1.44%     
==========================================
  Files           8       13       +5     
  Lines        1535     1966     +431     
==========================================
+ Hits         1213     1582     +369     
- Misses        276      329      +53     
- Partials       46       55       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov