Skip to content

DTLS 1.3: Add flights 0 and 1#829

Draft
theodorsm wants to merge 14 commits intomainfrom
flight_13_ch
Draft

DTLS 1.3: Add flights 0 and 1#829
theodorsm wants to merge 14 commits intomainfrom
flight_13_ch

Conversation

@theodorsm
Copy link
Copy Markdown
Member

Description

This PR aims to implement flight 0 (waiting server) and flight 1 (sending the first CH) for DTLS 1.3.

Blocked by #738

Reference issue

Partly fixes #825

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 46.92443% with 302 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.78%. Comparing base (fd27a52) to head (7e35f14).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
conn.go 59.71% 56 Missing and 29 partials ⚠️
flighthandlers_server_13.go 7.77% 80 Missing and 3 partials ⚠️
flighthandlers_client_13.go 54.95% 40 Missing and 10 partials ⚠️
flight_13.go 14.28% 36 Missing ⚠️
handshaker_13.go 58.46% 21 Missing and 6 partials ⚠️
flighthandler_13.go 42.85% 8 Missing ⚠️
util.go 68.18% 7 Missing ⚠️
pkg/protocol/handshake/handshake.go 0.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (46.92%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   82.44%   79.78%   -2.66%     
==========================================
  Files         121      126       +5     
  Lines        6928     7456     +528     
==========================================
+ Hits         5712     5949     +237     
- Misses        805     1050     +245     
- Partials      411      457      +46     
Flag Coverage Δ
go 79.78% <46.92%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theodorsm theodorsm force-pushed the flight_13_ch branch 2 times, most recently from 1fa4763 to 3718ba0 Compare April 23, 2026 10:53
DTLS implementations do not use the TLS 1.3 "compatibility mode"
described in Appendix D.4 of TLS13.
Comment thread flighthandlers_client_13.go Outdated
})

extensions = append(extensions, &extension.SupportedVersions{
Versions: []protocol.Version{protocol.Version1_3, protocol.Version1_2},
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should reflect config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DTLS 1.3 1-RTT handshake flights

1 participant