Skip to content

Re-implemented renegotiation extension to comply with RFC5746 and RFC5246#711

Merged
JoTurk merged 1 commit intopion:masterfrom
daanpape:fix-renegotiation-info
Aug 16, 2025
Merged

Re-implemented renegotiation extension to comply with RFC5746 and RFC5246#711
JoTurk merged 1 commit intopion:masterfrom
daanpape:fix-renegotiation-info

Conversation

@daanpape
Copy link
Copy Markdown
Contributor

@daanpape daanpape commented May 6, 2025

Description

In this pull request I have re-implemented the renegotiation extension headers to comply with RFC5746 and RFC5246. This is required for PionDTLS to work with WolfSSL which strictly follows these RFCs and stops to connection when the renegotiation extension is wrongly added to the ServerHello response.

Reference issue

Fixes #687

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.53%. Comparing base (f0c0987) to head (e3cf6bc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   78.55%   78.53%   -0.03%     
==========================================
  Files         101      101              
  Lines        6828     6834       +6     
==========================================
+ Hits         5364     5367       +3     
- Misses       1089     1092       +3     
  Partials      375      375              
Flag Coverage Δ
go 78.55% <100.00%> (-0.03%) ⬇️
wasm 57.15% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@nils-ohlmeier nils-ohlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoTurk JoTurk force-pushed the fix-renegotiation-info branch from 2017dac to a2c4d35 Compare August 16, 2025 10:55
- Re-implemented renegotiation to comply with RFC5746 and RFC5246
- Updated conn_test.go to comply with 120 column limit
@JoTurk JoTurk force-pushed the fix-renegotiation-info branch from a2c4d35 to e3cf6bc Compare August 16, 2025 10:55
@JoTurk JoTurk merged commit e3cf6bc into pion:master Aug 16, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It is prohibited to include the renegotiation_info extension in ServerHello if Renegotiation Indication Extension is not supported by client

3 participants