Fix enrichment in compare plots and compare plot diffs#626
Merged
kclem merged 1 commit intopinellolab:masterfrom Mar 13, 2026
Merged
Fix enrichment in compare plots and compare plot diffs#626kclem merged 1 commit intopinellolab:masterfrom
kclem merged 1 commit intopinellolab:masterfrom
Conversation
* Run diffs on the plots in integration tests * Correct diff-plots now * Pin matplotlib in test dependencies and update running integration tests * Fix cross-pollution of integration tests * Install MS core fonts in CI for consistent plot rendering CRISPResso2 requests Arial as the primary font via matplotlib's font.sans-serif setting. Without MS core fonts installed, the CI runner falls back to a different font, causing upset plots (and potentially others) to exceed the RMSE image comparison threshold. This matches the Dockerfile which already installs ttf-mscorefonts-installer. Also clears matplotlib's font cache so it discovers the newly installed fonts. * Remove matplotlib pin in tests and don't run diff-plots with Pro * Reorder base edit plots and update caption in Compare * Rebuild pixi fontconfig cache after MS font installation in CI The pixi/conda environment has its own fontconfig with a separate font cache (.pixi/envs/test/var/cache/fontconfig/). When the pixi environment is restored from actions/cache, this fontconfig cache is stale and doesn't know about the MS core fonts installed via apt-get. Running the system fc-cache only updates the system fontconfig, not the pixi one. Fix: run 'pixi run -e test -- fc-cache -f' to rebuild the pixi fontconfig cache so that matplotlib's findSystemFonts() discovers Arial via the pixi fc-list. * Update base editing caption in compare * Sort Compare allele plots by aligned sequence as well * Attempt to fix sorting of compare allele plots * Sort the df being passed into the plot in compare! * Sort the bottom compare plots too! * Make the tiebreaking logic in compare enrichment consistent * Cache MS fonts in pixi * Point integration tests back to master and revert pixi.toml * Fix mutating args directly in compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the comparison of plots and fixes the ordering of the enrichment of the allele quilts in CRISPRessoCompare.