Fix extractor reference races and deduplicate source references#59
Merged
perpetualKid merged 3 commits intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue in
GetText.Extractor, where source references in generated .pot could be incomplete. And also an issue that those references can contain duplicates, when plural form is used.CatalogTemplate.AddOrUpdateEntry(...)updates thread-safe per catalog entry. This fixed nondeterministic loss of source references during parallel extraction.CatalogTemplate.AddOrUpdateEntry(..)with plural form: reference is now added only when it is not added before, the same way as it already was done in non plural version if this method.Also extracted some duplicate logic into the newly introduced
CatalogTemplate.GetOrAddEntry(...).Added unit tests to verify both issues