Fix memory leak in utf8_decode via RAII#157
Open
jules-ai wants to merge 1 commit into
Open
Conversation
The `utf8_decode` function in `include/indicators/display_width.hpp` used raw `new` and `delete[]` to manage the buffer for `mbstowcs_s` and `mbstowcs`. This pattern is susceptible to memory leaks if an exception is thrown before `delete[]` is called, which can pose a security risk in a long-running process. This commit replaces the manual memory management with `std::wstring`. By initializing a string of sufficient size, passing its internal buffer to `mbstowcs`, and resizing it afterwards, the memory is managed safely and exception-safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
utf8_decodefunction ininclude/indicators/display_width.hppused rawnewanddelete[]to manage the buffer formbstowcs_sandmbstowcs. This pattern is susceptible to memory leaks if an exception is thrown beforedelete[]is called, which can pose a security risk in a long-running process.This commit replaces the manual memory management with
std::wstring. By initializing a string of sufficient size, passing its internal buffer tombstowcs, and resizing it afterwards, the memory is managed safely and exception-safe.