8346177: C2: optimize simple increment loops with loop-invariant strides#30473
Open
krk wants to merge 1 commit intoopenjdk:masterfrom
Open
8346177: C2: optimize simple increment loops with loop-invariant strides#30473krk wants to merge 1 commit intoopenjdk:masterfrom
krk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back krk! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
replace_parallel_ivonly optimized parallel IVs with constant increments that evenly divided the primary IV's stride. Patterns likea += fieldora += paramwhere the increment is loop-invariant but not a compile-time constant were left as accumulation loops.This patch generalizes the optimization to accept any loop-invariant increment, adds subtraction support, and removes the exact-divisibility requirement. Instead of computing a ratio between strides, the iteration count is computed directly as
(iv - init) / stride_con.A simple benchmark
for (i=0; i<100000; i++) a += inc, whereincis loop-invariant, shows the loop is fully eliminated by the patched JVM, reducing from ~7500 ns/call to ~17 ns/call.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30473/head:pull/30473$ git checkout pull/30473Update a local copy of the PR:
$ git checkout pull/30473$ git pull https://git.openjdk.org/jdk.git pull/30473/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30473View PR using the GUI difftool:
$ git pr show -t 30473Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30473.diff
Using Webrev
Link to Webrev Comment