8380988: C2: Unexpected node in SuperWord truncation: UModI/UDivI

[mhaessig]

This is a small fix for an assert failure in SuperWord truncation with UModI and UDivI nodes. The failure itself is harmless and does not lead to any miscompilations in the release build. I updated the big SuperWord truncation test with these two nodes.

Testing:

• Github Actions
• tier1,tier2,tier3 plus internal testing

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8380988: C2: Unexpected node in SuperWord truncation: UModI/UDivI (Bug - P4)

Reviewers

• Emanuel Peter (@eme64 - Reviewer)
• Jasmine Karthikeyan (@jaskarth - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30469/head:pull/30469
$ git checkout pull/30469

Update a local copy of the PR:
$ git checkout pull/30469
$ git pull https://git.openjdk.org/jdk.git pull/30469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30469

View PR using the GUI difftool:
$ git pr show -t 30469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30469.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380988: C2: Unexpected node in SuperWord truncation: UModI/UDivI

Reviewed-by: epeter, jkarthikeyan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 7e4ac14: 8380686: GenerateOopMap logging crashes in rewriter
• 7ffc4a4: 8381019: Remove AppContext usage from AccessBridge
• 79668b0: 8380710: nmethod::finalize_relocations() should be called before ICache::invalidate_range() is called
• ... and 10 more: https://git.openjdk.org/jdk/compare/cee1e040b3729309e0f9515c4852670226e5ca88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mhaessig]

@jaskarth, could you please take a look since you are familiar with this code?

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (4ba677bd)
• 01: Full - Incremental (a554ebf2)
• 00: Full (a0904e9a)

[eme64]

Nice, thanks for the fix and tests :)

[jaskarth]

This looks good!