Clarify Symphony service specification#61
Merged
Merged
Conversation
Summary: - Add RFC-style normative language and clarify config validation. - Separate core and extension-owned configuration docs. - Defer Codex app-server protocol details to the targeted Codex spec. - Clarify workspace root resolution, restart recovery, and user-input policy. Rationale: - Reduce ambiguity for implementors without changing the service model. - Keep extension fields owned by their defining sections so future extensions do not require editing core config summaries. - Avoid duplicating external Codex protocol schemas in this repository spec. Tests: - not run (documentation-only change) Co-authored-by: Codex <codex@openai.com>
Summary: - Uppercase RFC 2119 keywords across SPEC.md outside code fences. - Preserve hyphenated event names such as user-input-required. - Keep protocol example JSON field names unchanged. Rationale: - Make conformance requirements, recommendations, and optional behavior easier to scan after adding the normative language section. - Keep this as a separate mechanical pass from the substantive spec cleanup. Tests: - git diff --check - perl scan for lowercase RFC keywords outside code fences Co-authored-by: Codex <codex@openai.com>
ivanzzeth
referenced
this pull request
in ivanzzeth/symphony
May 3, 2026
#### Context SPEC.md had ambiguous conformance language and implementation details that made the service contract harder to port. #### TL;DR *Clarify SPEC.md and normalize RFC-style requirement wording.* #### Summary - Add normative language and tighten config, workspace, reload, restart, and user-input wording. - Move extension config ownership to extension sections. - Point Codex protocol details at the targeted app-server spec instead of duplicating payloads. - Run a careful RFC 2119 terminology pass after mechanical normalization. #### Alternatives - Left attempt/retry redesign and broader safety issues for follow-up spec changes. #### Test Plan - [x] `make -C elixir all` - [x] `git diff --check HEAD~1..HEAD` - [x] RFC keyword scan outside code fences --------- Co-authored-by: Codex <codex@openai.com>
chihsuan
added a commit
to Automattic/symphony
that referenced
this pull request
May 15, 2026
…telist feat(agent_env): strip secrets from agent subprocess env (RSM-3038)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SPEC.md had ambiguous conformance language and implementation details that made the service contract harder to port.
TL;DR
Clarify SPEC.md and normalize RFC-style requirement wording.
Summary
Alternatives
Test Plan
make -C elixir allgit diff --check HEAD~1..HEAD