feat: implements mode UV nano for air conditioner RAC_056905_WW#604
Open
jonasrodrigues93 wants to merge 1 commit intoollo69:masterfrom
Open
feat: implements mode UV nano for air conditioner RAC_056905_WW#604jonasrodrigues93 wants to merge 1 commit intoollo69:masterfrom
jonasrodrigues93 wants to merge 1 commit intoollo69:masterfrom
Conversation
ollo69
requested changes
Sep 24, 2023
Owner
ollo69
left a comment
There was a problem hiding this comment.
Thanks for this PR, but seems that some checks are missing:
- you should check that device support this feature, I think that not all LG AC device have UV Mode
- you should check that device is in valid status to enable this mode (e.g. probably does not mae sense enable this mode when AC is off)
Take a look to Jet Mode implementation to understand what I mean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements a new mode called UV Nano for air conditioner. This mode utilizes an ultraviolet light to eliminate biological organisms. For more information, please refer to LG's UV Nano Technology.
Entity
Create a switch entity to control the UV Nano mode.
Tests
I have tested this on my air conditioner with the following scenarios and results:
Scenario: Add device on Home Assistant via integration
Scenario: Turn on from Home Assistant
Scenario: Turn off from Home Assistant
Scenario: Turn on from IR control
Scenario: Turn off from IR control
All scenarios have passed successfully.
Since this is my first time creating or contributing to a custom component, I would greatly appreciate a code review or any suggestions to further improve this pull request.