Issue #1371#1372
Closed
SamuelRT123 wants to merge 3 commits into
Closed
Conversation
Ensures a single instance of MainActivity, automatically clearing the backstack when returning to home and preventing duplicate screens.
Fixes Android Lint warning by using stringResource() instead of querying resource values directly via LocalContext.
* **Avoid boxing**: Replaced `mutableStateOf<Int?>` with `mutableIntStateOf` for `highlightedItemId` to eliminate Integer heap allocation, using -1 as a sentinel value. * **Selection count optimization**: Wrapped `resolvedSelectionCount` and `resolvedCount` in `derivedStateOf` to prevent redundant calculations when unrelated state changes trigger recomposition. * **Stable LazyColumn keys**: Simplified item keys to use `rowKey(it)`, ensuring keys are stable and minimal. This prevents Compose from treating re-ordered items as new nodes, improving performance during sort operations. * **Logic cleanup**: Removed redundant comments and refined the measurement ID resolution logic.
Owner
|
Thanks for the PR. After review, I’m closing this PR. The The LazyColumn key change is not justified, as the current key is already stable and unique. Changing it does not provide a measurable benefit. The The Overall, the changes mix minor optimizations with architectural and behavioral modifications that are out of scope for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for problems reported in the issue #1371. Additionally, how Androir works with proccess and taks in the applications it's better to use SingleTask for the launch mode in AndroidManifest file.