Skip to content

[IMP] Add rotation classes, remove filter outdated css#17827

Open
nikibrown wants to merge 1 commit into
19.0from
19.0-phone-icon-rotate-nikbr
Open

[IMP] Add rotation classes, remove filter outdated css#17827
nikibrown wants to merge 1 commit into
19.0from
19.0-phone-icon-rotate-nikbr

Conversation

@nikibrown
Copy link
Copy Markdown
Contributor

@nikibrown nikibrown commented May 11, 2026

For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app.

Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily.

Also removed some old CSS that was for internet explorer 9 with rotation issues.

image

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 11, 2026

Pull request status dashboard

@nikibrown nikibrown requested review from AntoineVDV, huisit and samueljlieber and removed request for samueljlieber May 11, 2026 20:41
@nikibrown nikibrown changed the title Add rotation classes, remove filter outdated css [IMP ]Add rotation classes, remove filter outdated css May 11, 2026
@nikibrown nikibrown changed the title [IMP ]Add rotation classes, remove filter outdated css [IMP] Add rotation classes, remove filter outdated css May 11, 2026
Copy link
Copy Markdown
Contributor

@huisit huisit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikibrown works like a charm! This is exactly what we need to replicate the in-product Hang Up button, and it'll be great to rotate icons ourselves instead of asking for help every time there's a custom rotation. Thanks for your help on this :)

Copy link
Copy Markdown
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikibrown, you must check that all three CIs are green before marking the PR as ready for review. Then, reviewers will be automatically assigned depending on impacted files, without you needing to manually pick one.

@nikibrown nikibrown force-pushed the 19.0-phone-icon-rotate-nikbr branch from 9ae20c5 to a7b604f Compare May 13, 2026 22:39
@C3POdoo C3POdoo requested review from a team May 13, 2026 22:41
@nikibrown
Copy link
Copy Markdown
Contributor Author

Thanks @AntoineVDV should be all set now.

@AntoineVDV AntoineVDV removed the request for review from a team May 15, 2026 08:57
@nikibrown
Copy link
Copy Markdown
Contributor Author

@AntoineVDV Can you take a look at this (or whoever is supposed to review?) We have another PR that needs to use some of these rotation classes to make the phone icons accurate. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants