[IMP] Add rotation classes, remove filter outdated css#17827
Conversation
huisit
left a comment
There was a problem hiding this comment.
@nikibrown works like a charm! This is exactly what we need to replicate the in-product Hang Up button, and it'll be great to rotate icons ourselves instead of asking for help every time there's a custom rotation. Thanks for your help on this :)
AntoineVDV
left a comment
There was a problem hiding this comment.
Hi @nikibrown, you must check that all three CIs are green before marking the PR as ready for review. Then, reviewers will be automatically assigned depending on impacted files, without you needing to manually pick one.
9ae20c5 to
a7b604f
Compare
|
Thanks @AntoineVDV should be all set now. |
|
@AntoineVDV Can you take a look at this (or whoever is supposed to review?) We have another PR that needs to use some of these rotation classes to make the phone icons accurate. Thanks! |

For 19.0 and up there is a need to adjust the rotation of the font awesome icons (specifically fa-phone) to match the ui in the Odoo phone app.
Rather than creating a one off class for the phone icon, I used a sass loop to generate rotation classes in 5 degree increments so future icon adjustments can happen easily.
Also removed some old CSS that was for internet explorer 9 with rotation issues.