Chore/nodemailer 8 peer deps#13434
Open
Amanek93 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@Amanek93 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This PR sets the optional
nodemailerpeer dependency (plus aligned manifests /pnpm-lock.yaml, includingnext-authdevDependency) to^8.0.5so installs compatible with Auth.js must use Nodemailer patched for GHSA-vvjj-xcjg-gr5g.This PR only adjusts declared compatibility with already-published nodemailer; it does not disclose a new, unreleased vulnerability in Auth.js.
Context: That advisory covers SMTP command injection via CRLF in the transport
nameoption (EHLO/HELO/LHLO). In the published OSV semver range the issue isintroduced: 0→fixed: 8.0.5— i.e. every release strictly before8.0.5is affected (including Nodemailer 7.x and 8.0.0–8.0.4). The fix is in nodemailer v8.0.5.Why
^8.0.5: A range like^8.0.0can still resolve 8.0.4 and other unpatched 8.0.x;^8.0.5matches the published fix boundary and avoids misleading „safe 8.x” installs.Code impact: No runtime changes to the Auth.js Nodemailer integration — only dependency declarations. The provider still uses
createTransportfromnodemailer; there are no checks in this repo on theNoAuth→ENOAUTHrename from Nodemailer v8.🧢 Checklist
pnpm --filter @auth/core build,pnpm --filter next-auth build,pnpm --filter next-auth test)🎫 Affected issues
No specific issue linked; addresses npm/pnpm peer compatibility with safe Nodemailer versions and GHSA-vvjj-xcjg-gr5g.
📌 Resources