Conversation
|
Mateusz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Netdata Helm chart’s OpenTelemetry deployment to persist /var/lib/netdata across pod restarts so the agent retains state (e.g., claim identity) instead of reappearing as a new instance in Netdata Cloud.
Changes:
- Add a second PVC (
*-otel-varlib) and mount it at/var/lib/netdatain the netdata-otel Deployment. - Update
values.yaml/README wording around OTel persistence, and change the defaultnetdataOpentelemetry.dnsPolicy.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| charts/netdata/values.yaml | Updates netdata-otel defaults/docs for persistence and changes dnsPolicy default. |
| charts/netdata/templates/netdata-otel/persistentvolumeclaim.yaml | Adds a new *-otel-varlib PVC alongside the existing *-otel-varlog PVC. |
| charts/netdata/templates/netdata-otel/deployment.yaml | Mounts the new varlib PVC at /var/lib/netdata and wires the new claim into pod volumes. |
| charts/netdata/README.md | Mirrors the updated values.yaml defaults/text in the generated values table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
590f98d to
225d23e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for the change - varlib volume is missing so restarting the pod will create a new instance in the netdata cloud.
@ilyam8 @witalisoft
I tried to do this under one parameter because our
values.yaml- not because of laziness but because thevalues.yamlis quite long so lemme know if hardcoding the varlib volume into 1Gi and making it all under 1 switch makes sense. I can't imagine it going full ever.