Skip to content

adding missing volume for netdata-otel#523

Merged
M4itee merged 4 commits intomasterfrom
fix/missing-volume-otel
Mar 23, 2026
Merged

adding missing volume for netdata-otel#523
M4itee merged 4 commits intomasterfrom
fix/missing-volume-otel

Conversation

@M4itee
Copy link
Copy Markdown
Contributor

@M4itee M4itee commented Mar 20, 2026

Reason for the change - varlib volume is missing so restarting the pod will create a new instance in the netdata cloud.

@ilyam8 @witalisoft
I tried to do this under one parameter because our values.yaml - not because of laziness but because the values.yaml is quite long so lemme know if hardcoding the varlib volume into 1Gi and making it all under 1 switch makes sense. I can't imagine it going full ever.

@M4itee M4itee requested review from a team and ilyam8 as code owners March 20, 2026 10:59
@M4itee M4itee requested a review from witalisoft March 20, 2026 10:59
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 20, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ M4itee
❌ Mateusz


Mateusz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Netdata Helm chart’s OpenTelemetry deployment to persist /var/lib/netdata across pod restarts so the agent retains state (e.g., claim identity) instead of reappearing as a new instance in Netdata Cloud.

Changes:

  • Add a second PVC (*-otel-varlib) and mount it at /var/lib/netdata in the netdata-otel Deployment.
  • Update values.yaml/README wording around OTel persistence, and change the default netdataOpentelemetry.dnsPolicy.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
charts/netdata/values.yaml Updates netdata-otel defaults/docs for persistence and changes dnsPolicy default.
charts/netdata/templates/netdata-otel/persistentvolumeclaim.yaml Adds a new *-otel-varlib PVC alongside the existing *-otel-varlog PVC.
charts/netdata/templates/netdata-otel/deployment.yaml Mounts the new varlib PVC at /var/lib/netdata and wires the new claim into pod volumes.
charts/netdata/README.md Mirrors the updated values.yaml defaults/text in the generated values table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

M4itee and others added 2 commits March 20, 2026 13:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
witalisoft
witalisoft previously approved these changes Mar 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@M4itee M4itee merged commit 27f2d43 into master Mar 23, 2026
6 checks passed
@M4itee M4itee deleted the fix/missing-volume-otel branch March 23, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants