fix: isObject and isArray not working in V8 isolates#75
Open
luke07758 wants to merge 1 commit intomuratgozel:masterfrom
Open
fix: isObject and isArray not working in V8 isolates#75luke07758 wants to merge 1 commit intomuratgozel:masterfrom
luke07758 wants to merge 1 commit intomuratgozel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v.constructor === Objectandv.constructor === Arrayconditions do not work as expected when using V8 isolates. Using the setSender and setTo functions (from "mimetext/browser") resulted in errors on Next.js server components with edge runtime. Upon debugging, the aforementioned conditions were evaluating to false despite passing objects and strings exactly as described in the docs.I believe the issue is due to the object/string being passed in from a different context which leads to it having a different reference, causing that condition to be false.
I replaced the object condition with
Object.prototype.toString.call(v) === '[object Object]'as this works across contexts and will not have false positives on Array, Date, etc. (I assumed only plain objects should be accepted here)As for the Array comparison,
Array.isArray(v)works perfectly fine, and I removed theisArrayfunction as checking!!vis redundant when using the built-in function for this.With these changes, there are no errors when running in V8 isolates.