[code-infra] Setup workflow to publish internal packages by brijeshb42 · Pull Request #47952 · mui/material-ui

brijeshb42 · 2026-03-11T17:02:38Z

whenever a new commit lands in master.

Currently, kept it manual with workflow_dispatch check. Don't want to publish packages as soon as it gets merged. I'll trigger it manually to do some testing and then after some time, check the check to also include push check.

One other major change - Renamed @mui/docs to @mui/internal-core-docs and moved this and other internal packages to packages-internal.

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2026-03-11T17:03:39Z

Netlify deploy preview

Bundle size report

Bundle	Parsed size	Gzip size
@mui/material	0B^(0.00%)	0B^(0.00%)
@mui/lab	0B^(0.00%)	0B^(0.00%)
@mui/system	0B^(0.00%)	0B^(0.00%)
@mui/utils	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against b70b06d

Janpot · 2026-03-11T17:22:17Z

.github/workflows/publish.yml

+          pnpm code-infra publish-canary --package @mui/internal-markdown @mui/docs @mui/internal-scripts @mui-internal/api-docs-builder @mui/internal-docs-utils
+
  publish:
+    if: github.event_name == 'workflow_dispatch'


What if we want to use workflow_dispatch to test the canary publishing?

you mean for the new job publish-internal ? I can add the workflow_dispatch check there as well if desired. I don't see the need.
As soon as this PR gets merged, it'll trigger a publish anyways and can be tested there. And you cannot trigger manually from a branch anyways for testing.

I have explicitly kept workflow_dispatch check in the previous publish job since I also added the on.push.branches trigger.

I believe with workflow_dispatch it's possible to test a change in a PR without merging first.

Hmm. Seems for that this needs to exist first in the main branch then we can trigger for next PR. I'll add the check.

No. Because you choose the workflow to trigger from github actions page list first. It'll be shown as two separate items in the workflow list.

Are you sure, that's not my experience when trying the "Publish packages" workflow_dispatch in mui-public. Maybe I'm looking at the wrong thing.

Also, when we're calling this from CLI, won't it also trigger canary publishing along side regular publishing?

Now I am not sure. I am moving this to its own file just to make sure there is no scenario of what you mention. I can verify after merge from the Actions UI, what it shows.

I am moving this to its own file

That's not possible, trusted publishing needs to be configured with a workflow file to publish from, and only one file can be configured.

Then looks like one more input is needed from user side on the workflow to decide which job to trigger.

brijeshb42 · 2026-03-19T18:29:07Z

.github/workflows/publish-internal.yml

+        description: 'Run in dry-run mode without actually publishing packages'
+        required: false
+        type: boolean
+        default: false


removing github release since its not relevant here and tag input since it'll always be canary.

Janpot · 2026-03-20T05:42:37Z

.github/workflows/publish.yml

        required: false
        type: string
        default: 'latest'
+      internal-packages-only:


Nitpick, but the name seems to imply that when this is false, both internal and public are published.

Janpot · 2026-03-20T05:45:55Z

Now I remember what the problem was, we've set up a github actions environment that mandates a manual approval. This is configured in trusted publishing as well.

brijeshb42 · 2026-03-20T05:47:40Z

Do we want to add the environment for internal packages as well ? I don't see it configured for mui-public here.

Janpot · 2026-03-23T06:32:56Z

Do we want to add the environment for internal packages as well?

~~Ideally we don't, but environment has to be configured in the trusted publishing settings on npm. In mui-public packages, the environment is not configured on npm.~~

~~edit: just noticed there's a new feature that could allow us to create custom protection rules. We'll have to look into this.~~

edit 2: ok, I was talking nonsense, hadn't taken my shower yet. I was operating under the assumption @mui/docs still needed to be published through the regular flow. But what we could try is to split the packages exclusively in two, the public ones that only publish through the regular release flow, and the code infra ones that only publish through the canary flow. (to note that we should make sure there can never be workspace: dependencies between the two). The latter we publish with an npm-publish-internal environment, which doesn't include the manual review, but which only allows for publishing from master branch.

brijeshb42 · 2026-03-23T08:37:06Z

the public ones that only publish through the regular release flow

This means that we need to filter out the internal/docs ones from the normal release flow so that these packages don't have two releases. I'll check what needs to be changed to filter out specific packages from the code-infra publish command.

Janpot · 2026-03-23T08:39:58Z

This means that we need to filter out the internal/docs ones from the normal release flow so that these packages don't have two releases.

Yep, otherwise one of the publishes for that double package will fail due to publishing from a different environment than configured.

Janpot · 2026-03-26T17:51:16Z

.github/workflows/publish.yml


 jobs:
+  publish-internal:
+    # Keeping it manual trigger only for now. Will update to also include ` || (github.event_name == 'push' && github.event.head_commit.author.name != 'renovate[bot]')` once we are ready to publish internal packages on push as well.


👍 good idea

whenever a new commit lands in master.

…ackages-internal/` - Rename package: `@mui/docs` → `@mui/internal-core-docs` - Move directory: `packages/mui-docs/` → `packages-internal/mui-internal-core-docs/` - Update all import references across docs/, packages/, and config files - Update tsconfig.json, babel.config.mjs, eslint.config.mjs path aliases - Update .github/workflows/publish.yml filter flags - Update tsconfig.build.json references to use correct relative paths from new location - Run pnpm install to register new workspace package location

The wildcard "./*" only resolves to index.ts files, so the non-index `src/ApiPage/private.ts` entry-point was missing from the generated build/package.json, causing the docs production build to fail.

…kages-internal/markdown`

…ackages-internal/waterfall`

…kages-internal/`

… `packages-internal/`

…`packages-internal/` - Add `@mui-internal/api-docs-builder` and `@mui-internal/api-docs-builder-core` path aliases to root tsconfig.json (used by docs and other consumers) - Add explicit `@mui/internal-markdown/prism` alias pointing to prism.d.mts (not found via wildcard due to .mts extension) - Add self-referencing path aliases in api-docs-builder's own tsconfig.json to resolve `@mui-internal/api-docs-builder` internally under nodenext resolution

brijeshb42 requested a review from a team March 11, 2026 17:02

brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Mar 11, 2026

brijeshb42 force-pushed the canary-publish branch from 2fd2464 to fd5cbe6 Compare March 11, 2026 17:06

Janpot reviewed Mar 11, 2026

View reviewed changes

brijeshb42 force-pushed the canary-publish branch from fd5cbe6 to d24760e Compare March 12, 2026 06:38

brijeshb42 requested a review from Janpot March 12, 2026 09:33

brijeshb42 force-pushed the canary-publish branch 2 times, most recently from 7b45015 to 96c38da Compare March 12, 2026 15:51

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 13, 2026

brijeshb42 force-pushed the canary-publish branch from 96c38da to 0fd3e57 Compare March 16, 2026 09:10

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 16, 2026

brijeshb42 force-pushed the canary-publish branch 4 times, most recently from 47bf6be to eda494a Compare March 19, 2026 18:28

brijeshb42 commented Mar 19, 2026

View reviewed changes

brijeshb42 force-pushed the canary-publish branch from eda494a to 096e04b Compare March 20, 2026 02:34

Janpot reviewed Mar 20, 2026

View reviewed changes

brijeshb42 force-pushed the canary-publish branch from 096e04b to 484dcca Compare March 23, 2026 04:28

brijeshb42 requested a review from Janpot March 23, 2026 04:28

brijeshb42 force-pushed the canary-publish branch from 484dcca to 484eeb9 Compare March 23, 2026 07:05

brijeshb42 mentioned this pull request Mar 23, 2026

[code-infra] Modify publish script to filter packages mui/mui-public#1236

Merged

brijeshb42 force-pushed the canary-publish branch 2 times, most recently from b0b05a5 to f100d09 Compare March 23, 2026 11:46

brijeshb42 force-pushed the canary-publish branch from d58d586 to bca55c7 Compare March 25, 2026 10:28

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 25, 2026

brijeshb42 force-pushed the canary-publish branch from 5ecf54f to 418d03e Compare March 26, 2026 07:58

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Mar 26, 2026

brijeshb42 force-pushed the canary-publish branch from d6761c8 to 6ef2713 Compare March 26, 2026 08:39

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 26, 2026

Janpot reviewed Mar 26, 2026

View reviewed changes

brijeshb42 force-pushed the canary-publish branch from 6ef2713 to bd43270 Compare March 27, 2026 07:18

brijeshb42 added 18 commits March 27, 2026 14:53

[code-infra] Setup workflow to auto publish internal packages

1db4a20

whenever a new commit lands in master.

Review fix

3b95990

Exclude internal packages from publishing

c0324ce

[core-docs] Add ./ApiPage/private to package exports

53ca326

The wildcard "./*" only resolves to index.ts files, so the non-index `src/ApiPage/private.ts` entry-point was missing from the generated build/package.json, causing the docs production build to fail.

[repo] Fix remaining @mui/docs references in vite/next configs

14fefd2

Dedupe

fbdd2c3

[repo] Fix @mui/docs alias in vitest.shared.mts

3a8248f

[repo] Move @mui/internal-markdown from packages/markdown to `pac…

c85b893

…kages-internal/markdown`

[repo] Move @mui/internal-waterfall from packages/waterfall to `p…

c004941

…ackages-internal/waterfall`

[repo] Move @mui-internal/api-docs-builder from packages/ to `pac…

7e7af65

…kages-internal/`

[repo] Move @mui-internal/api-docs-builder-core from packages/ to…

869bd24

… `packages-internal/`

chore: update caniuse-lite to 1.0.30001781 to support Edge 146

94aeaf3

Dedupe

3ac0e70

Bump code-infra package

899926c

Add missing alias

17d37d0

Fix build

b70b06d

brijeshb42 requested a review from a team March 27, 2026 09:23

brijeshb42 force-pushed the canary-publish branch from bd43270 to b70b06d Compare March 27, 2026 09:23

brijeshb42 requested a review from Janpot March 27, 2026 09:23

Uh oh!

Conversation

brijeshb42 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot commented Mar 20, 2026

Uh oh!

brijeshb42 commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Janpot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brijeshb42 commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Janpot commented Mar 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brijeshb42 commented Mar 11, 2026 •

edited

Loading

mui-bot commented Mar 11, 2026 •

edited

Loading

brijeshb42 Mar 11, 2026 •

edited

Loading

brijeshb42 commented Mar 20, 2026 •

edited

Loading

Janpot commented Mar 23, 2026 •

edited

Loading

brijeshb42 commented Mar 23, 2026 •

edited

Loading