feat(deploy): Allow setting remote for trigger:dot-release script#20596
Open
LZoog wants to merge 1 commit into
Open
feat(deploy): Allow setting remote for trigger:dot-release script#20596LZoog wants to merge 1 commit into
LZoog wants to merge 1 commit into
Conversation
LZoog
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dot-release tagging script so it no longer assumes the origin remote, enabling release tagging/pushing against an alternate Git remote when needed.
Changes:
- Allow overriding the Git remote used by
_scripts/trigger-dot-release.shviaREMOTE, defaulting toorigin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
32
to
36
| minor="${BASH_REMATCH[2]}" | ||
| branch="train-${minor}" | ||
| remote="origin" | ||
| remote="${REMOTE:-origin}" | ||
|
|
||
| echo "Fetching latest tags from ${remote}..." |
Contributor
There was a problem hiding this comment.
I also think there's a small chance someone has REMOTE set to something random in their env, just cause its such a ubiquitous term... So maybe GIT_FXA_REMOTE would be less likely to collide?
Contributor
Author
There was a problem hiding this comment.
Fair point, will update! Though I think FXA_REMOTE should be OK.
LZoog
force-pushed
the
trigger-script-remote-option
branch
from
79187bb to
56d124c
Compare
Because: * The script assumes mozilla/fxa is set to 'origin' This commit: * Allows passing FXA_REMOTE= to specify a different remote
LZoog
force-pushed
the
trigger-script-remote-option
branch
from
56d124c to
0fb600e
Compare
dschom
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
FXA_REMOTE=to specify a different originnote to self: update confluence docs when this lands