Enable language server tests for GitHub PR's#14474
Draft
bobbrow wants to merge 1 commit into
Draft
Conversation
bobbrow
force-pushed
the
bobbrow/enableLSTests
branch
from
f072392 to
8176bfe
Compare
bobbrow
force-pushed
the
bobbrow/enableLSTests
branch
from
8176bfe to
98653af
Compare
Contributor
|
@bobbrow These are failing on Mac/Linux. |
Member
Author
I'm not sure what you mean. Tests are currently disabled due to a breaking change in the LSP since the latest release. They are currently "passing" by being skipped. I'm going to leave this in draft until we ship 1.33.0 so I can make sure tests work at that point. Tests worked on all platforms when I was testing against 1.31.4 (where my branch was snapped when I started on this). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables running the end to end tests as part of a PR in the vscode-cpptools repo.
caveat: This is dependent on there being no breaking changes in the cpptools binaries that would cause tests to fail. When that is the case, the
minBinaryVersion.jsonfile in thetestfolder should be updated to pause running the automated tests until a new extension version is published to the Marketplace.