NodeAgent onboarding: send register sets to coordinator at startup#104
Open
1ntEgr8 wants to merge 1 commit intousers/elton/telemetry-infrastructurefrom
Open
NodeAgent onboarding: send register sets to coordinator at startup#1041ntEgr8 wants to merge 1 commit intousers/elton/telemetry-infrastructurefrom
1ntEgr8 wants to merge 1 commit intousers/elton/telemetry-infrastructurefrom
Conversation
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
59cf112 to
8afcfbe
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
4f14857 to
566631e
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
8afcfbe to
c2fc1b8
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
566631e to
c767906
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
c2fc1b8 to
24089c6
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
c767906 to
5ce2cbf
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
24089c6 to
253705b
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
5ce2cbf to
d854f01
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
253705b to
75615e9
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
d854f01 to
baa3a30
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
75615e9 to
c9b9866
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
baa3a30 to
79fb5d8
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
3 times, most recently
from
c9b9866 to
513c2e4
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
79fb5d8 to
cb2b937
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
513c2e4 to
785abed
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
cb2b937 to
ced7715
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
785abed to
934ddf6
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
ced7715 to
d0a76a6
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
934ddf6 to
6891e02
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
d0a76a6 to
60fc949
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
6891e02 to
a9ca420
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
2 times, most recently
from
ce50a07 to
0638f2d
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
2 times, most recently
from
a9ca420 to
1e612fe
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
0638f2d to
158e273
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
1e612fe to
fb5e8ec
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
158e273 to
1acf837
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
fb5e8ec to
a4d12f2
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
1acf837 to
398c69c
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
a4d12f2 to
4efae8a
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
2 times, most recently
from
d3bdad3 to
8727bd7
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
4efae8a to
3994c0b
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
8727bd7 to
e0f801b
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
3994c0b to
3aeb805
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
2 times, most recently
from
661f17d to
e0f801b
Compare
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
3aeb805 to
3994c0b
Compare
NodeAgents now send their per-device register set information to the Coordinator during onboarding. This enables the Planner to allocate intermediate registers at the correct sizes for multi-hop routing. Key changes: - Add OnboardNodeAgentRequest/Response messaging - Add RegisterSet with uniform factory and per-device tracking - NodeAgent constructs register sets from worker devices and sends them during onboarding handshake - Coordinator Handler receives and passes sets to Planner - Planner stores per-participant register sets for backend use - Update NCCL backend to use RegisterSet for buffer allocation - Fix data race: route onboarding through Executor thread via ExecutorTask variant so Planner is only accessed from one thread
1ntEgr8
force-pushed
the
users/elton/telemetry-infrastructure
branch
from
3994c0b to
031bcf9
Compare
1ntEgr8
force-pushed
the
users/elton/nodeagent-onboarding
branch
from
e0f801b to
5520148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary