Skip to content

[internal/hcs] Migrate package from HCS V1 to V2 #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rawahars wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[internal/hcs] Migrate package from HCS V1 to V2 #2735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/gcs/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ func (p *Process) ExitCode() (_ int, err error) {
return -1, errors.New("process not exited")
}
if err := p.waitCall.Err(); err != nil {
return -1, err
var rerr *rpcError
if !errors.As(err, &rerr) || uint32(rerr.result) != hrNotFound {
return -1, err
}
}
return int(p.waitResp.ExitCode), nil
}
Expand Down Expand Up @@ -274,7 +277,8 @@ func (p *Process) Stdio() (stdin io.Writer, stdout, stderr io.Reader) {
// Wait waits for the process (or guest connection) to terminate.
func (p *Process) Wait() error {
p.waitCall.Wait()
return p.waitCall.Err()
_, err := p.ExitCode()
return err
}

func (p *Process) waitBackground() {
Expand Down
163 changes: 0 additions & 163 deletions internal/hcs/callback.go
View file
Open in desktop

This file was deleted.

Loading
Loading