fix(duct-tape): align pagination/refetch callback with Relay onComplete#650
Merged
alloy merged 3 commits intomicrosoft:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns duct-tape’s pagination/refetch callback option naming with Relay.
Relay uses
onCompleteforloadNext/refetch completion callbacks, while duct-tape only supportedonCompleted. That mismatch caused Relay-style options to be ignored at runtime unless users passed both keys manually.Changes
onComplete?: (error: Error | null) => voidtoRefetchOptions.onCompletedas a backward-compatible alias and marked it deprecated in type docs.onCompleteonCompletedloadNext/loadPreviousflowBackward Compatibility
onCompletedcontinue to work.onComplete.Tests
compiledHookstests to cover:onCompleteinvocation on success/erroronCompletedalias invocation on success/error@graphitation/apollo-react-relay-duct-tapefrom this branch and verifying callback behavior from the consumer side.Why
This removes a compatibility trap where Relay-style
onCompletewas not invoked under duct-tape runtime behavior.