-
Notifications
You must be signed in to change notification settings - Fork 13
Add endgame skill and 0.18.0 test plans (duzitong tasks) #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
duzitong
wants to merge
3
commits into
main
Choose a base branch
from
endgame-skill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| --- | ||
| name: endgame | ||
| description: Orchestrate endgame verification for a GitHub milestone issue. Fetches the issue, parses assigned tasks, delegates each task to a subagent that researches the linked PR/issue and writes a test plan, and saves every plan to test-plans/ following the project's standard test-plan format. | ||
| --- | ||
|
|
||
| # Endgame Verification Skill | ||
|
|
||
| Use this skill to run an endgame verification pass for a GitHub milestone issue. | ||
| Each task in the issue is delegated to a subagent that researches the linked | ||
| PR/issue and writes a test plan under `test-plans/`. | ||
|
|
||
| ## Workflow | ||
|
|
||
| **⚠️ CRITICAL — YOU MUST FOLLOW THESE RULES:** | ||
|
|
||
| 1. **Do NOT run `gh pr view` or `gh issue view` for individual tasks** — only | ||
| run it once for the main endgame issue. | ||
| 2. **Do NOT research or analyse any task yourself.** | ||
| 3. **Do NOT create any test-plan files yourself.** | ||
| 4. **IMMEDIATELY call `runSubagent` for each task** after parsing the issue — | ||
| no delays, no research. | ||
|
|
||
| --- | ||
|
|
||
| ### Step 1 — Ask the user for inputs | ||
|
|
||
| Ask for: | ||
| - The GitHub endgame issue URL | ||
| (e.g. `https://github.com/microsoft/copilot-for-eclipse/issues/XXXX`) | ||
| - The user's GitHub account name | ||
|
|
||
| --- | ||
|
|
||
| ### Step 2 — Fetch the endgame issue (ONE call only) | ||
|
|
||
| ```shell | ||
| gh issue view <issue_number> --repo microsoft/copilot-for-eclipse --json body --jq '.body' | ||
| ``` | ||
|
|
||
| Parse the body to find **all tasks (checkboxes) assigned to the specified | ||
| user**. Extract each task's title and any linked PR/issue URL as plain text. | ||
|
duzitong marked this conversation as resolved.
|
||
|
|
||
| **STOP — do NOT fetch any of the linked PRs or issues.** | ||
|
|
||
| --- | ||
|
|
||
| ### Step 3 — Process each task via subagent | ||
|
|
||
| For each task, call `runSubagent` with: | ||
| - **description**: `"Endgame: <short_task_title>"` | ||
| - **prompt**: the template below, filled in with only the info you extracted. | ||
|
|
||
| #### Subagent prompt template | ||
|
|
||
| --- | ||
| ## Task Details | ||
| - Task Number: \<N\> | ||
| - Task Title: \<task_title\> | ||
| - Assignee: \<username\> | ||
| - Related Issue/PR: \<link_if_available\> (NOT YET FETCHED — you must fetch this) | ||
|
|
||
| ## Your Mission | ||
|
|
||
| YOU (the subagent) must research this task AND create the test-plan file. | ||
|
|
||
| ### Step 1: Research the task | ||
|
|
||
| - Fetch the linked PR or issue with `gh pr view` / `gh issue view`. | ||
| - Understand what feature or fix needs to be verified. | ||
| - **If anything is ambiguous or unclear after reading the PR/issue, ask the | ||
| user for clarification before proceeding. Keep asking until you have enough | ||
| information to write concrete, accurate test steps.** | ||
|
|
||
| ### Step 2: Create the test-plan file | ||
|
|
||
| Determine a short `<feature-slug>` (lowercase, hyphens, no special chars) | ||
| derived from the task title (e.g. `chat-history-restore`). | ||
|
|
||
| Create the directory and file: | ||
|
|
||
| ``` | ||
| test-plans/<feature-slug>/<feature-slug>.md | ||
| ``` | ||
|
|
||
| Use **exactly** this format, matching the project's existing test plans | ||
| (see `test-plans/thinking-persistence/thinking-persistence.md` for a live | ||
| example): | ||
|
|
||
| ```markdown | ||
| # <Feature / Task Title> | ||
|
|
||
| ## Overview | ||
| <1–3 sentences: what is being verified and why it matters.> | ||
|
|
||
| --- | ||
|
|
||
| ## Test Cases | ||
|
|
||
| ### TC-001: <Specific test case title> | ||
|
|
||
| **Type:** `Happy Path` | ||
| **Priority:** `P0` | ||
|
|
||
| #### Preconditions | ||
| - <Specific state required before starting these steps> | ||
|
|
||
| #### Steps | ||
| 1. <Detailed, concrete step> | ||
| 2. <Next step> | ||
| 3. <Continue as needed> | ||
|
|
||
| #### Expected Result | ||
| - <Observable outcome that proves the feature works> | ||
|
|
||
| #### 📸 Key Screenshots | ||
| - [ ] **<Label>** — <What to capture> | ||
|
|
||
| --- | ||
|
|
||
| ### TC-002: <Next scenario if needed> | ||
| <!-- Repeat TC block for each distinct scenario. Use TC-003, TC-004, … --> | ||
|
|
||
| --- | ||
|
|
||
| ## Screenshots Checklist | ||
| > Consolidated list of all key screenshot moments. | ||
|
|
||
| - [ ] `TC-001` <Label> | ||
| - [ ] `TC-002` <Label> | ||
| ``` | ||
|
|
||
| Guidelines: | ||
| - **Overview**: 1–3 sentences max. Do not repeat what is already covered by | ||
| Preconditions or Steps. | ||
| - **Type** values: `Happy Path`, `Negative`, `Edge Case`, `Regression`. | ||
| - **Priority** values: `P0` (must-pass), `P1` (high), `P2` (medium). | ||
| - Use 3-digit zero-padded TC numbers: TC-001, TC-002, TC-003, … | ||
| - Omit `📸 Key Screenshots` within a TC block if there are no meaningful | ||
| screenshots to capture for that case. | ||
| - Keep the `## Screenshots Checklist` section at the end — list every | ||
| screenshot across all TC blocks. | ||
| - If you are still unsure about any step after researching, **ask the user** | ||
| before writing that step — do not guess. | ||
|
|
||
| ### Step 3: Return a brief summary | ||
|
|
||
| Return ONLY: | ||
| - File path created (e.g. `test-plans/chat-history-restore/chat-history-restore.md`) | ||
| - One-line summary of what needs to be verified | ||
|
|
||
| --- | ||
|
|
||
| ### Step 4 — Final summary | ||
|
|
||
| After all subagents complete, provide: | ||
| - A table of all generated test-plan files | ||
| - Total tasks processed | ||
| - Any tasks that could not be processed (with reasons) | ||
|
|
||
| --- | ||
|
|
||
| ## Notes | ||
|
|
||
| - **NEVER run `gh pr view` or `gh issue view` on task links yourself** — only | ||
| on the main endgame issue. Subagents handle the individual links. | ||
| - **NEVER analyse or research tasks yourself** — immediately delegate to | ||
| subagents. | ||
| - Each subagent runs independently. | ||
| - Subagents should be concise — create the file and return a brief summary. | ||
| - If a task is still unclear after the user is asked, note the outstanding | ||
| question inside the test-plan file. | ||
| - Use slugified task titles for the feature slug and directory name | ||
| (lowercase, hyphens, no special characters). | ||
31 changes: 31 additions & 0 deletions
31
com.microsoft.copilot.eclipse.swtbot.test/probe-scripts/endgame-chat-open-001.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| [ | ||
| { "action": "waitForIdle" }, | ||
| { "action": "screenshot", "id": "01-startup" }, | ||
|
|
||
| { "action": "showView", "idRef": "com.microsoft.copilot.eclipse.ui.chat.ChatView" }, | ||
| { "action": "waitForIdle" }, | ||
| { "action": "screenshot", "id": "02-chat-open" }, | ||
|
|
||
| { "action": "assertExists", | ||
| "locator": { "by": "viewId", "id": "com.microsoft.copilot.eclipse.ui.chat.ChatView" } }, | ||
|
|
||
| { "action": "waitFor", | ||
| "locator": { "by": "styledText" }, | ||
| "timeoutSec": 30 }, | ||
|
|
||
| { "action": "dumpUi", "id": "03-chat-widgets" }, | ||
| { "action": "screenshot", "id": "03-chat-ready" }, | ||
|
|
||
| { "action": "waitForMethod", | ||
| "locator": { "by": "widgetId", "value": "model-picker" }, | ||
| "method": "getSelectedItemId", | ||
| "timeoutSec": 60 }, | ||
|
|
||
| { "action": "screenshot", "id": "04-model-loaded" }, | ||
| { "action": "assertExists", | ||
| "locator": { "by": "widgetId", "value": "model-picker" } }, | ||
|
|
||
| { "action": "screenshot", "id": "05-final" }, | ||
| { "action": "assertExists", | ||
| "locator": { "by": "styledText" } } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.