Skip to content

fix: [Agentic Apps] - Two chat history titles for current chat #288

Open
Tejasri-Microsoft wants to merge 2 commits intomicrosoft:devfrom
Tejasri-Microsoft:aap-psl-bug-dup
Open

fix: [Agentic Apps] - Two chat history titles for current chat #288
Tejasri-Microsoft wants to merge 2 commits intomicrosoft:devfrom
Tejasri-Microsoft:aap-psl-bug-dup

Conversation

@Tejasri-Microsoft
Copy link

This pull request improves the handling of chat conversation history in the application, with a focus on preventing duplicate conversations and ensuring correct updates to the conversation list. It also introduces minor code cleanups and improves the reliability of saving chat data.

Conversation history deduplication and update logic:

  • Added a dedupeConversationsById utility to ensure the conversation list contains only unique conversations by ID, and integrated it into reducers and async state updates in chatHistorySlice.ts. [1] [2] [3]
  • Updated the addNewConversation reducer to merge data if a conversation with the same ID already exists, moving the updated conversation to the top of the list.

Chat component logic improvements:

  • Modified the logic in Chat.tsx to check for existing conversations before adding new ones, and to use the correct conversation ID when updating or selecting conversations. [1] [2]

Async data persistence:

  • Updated all calls to saveToDB in Chat.tsx to use await, ensuring that chat and chart data are reliably persisted before proceeding. [1] [2] [3]

Code cleanup:

  • Removed unused imports and code related to workshop mode, simplifying the chart parsing logic in Chat.tsx. [1] [2]## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • [ x] No

Golden Path Validation

  • [ x] I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • [x
    This pull request improves the reliability and consistency of chat conversation management in the application. The main focus is on preventing duplicate conversations in the chat history, ensuring that conversation updates are handled correctly, and improving the robustness of asynchronous operations when saving chat data.

Chat history deduplication and consistency:

  • Added a dedupeConversationsById utility function in chatHistorySlice.ts to ensure the chat history list contains only unique conversations by their id, preventing duplicates when adding or updating conversations.
  • Updated the addConversations and chat history fetch reducers to use dedupeConversationsById, ensuring no duplicate conversations are introduced during bulk additions or pagination. [1] [2]
  • Enhanced the addNewConversation reducer to merge with existing conversations if a conversation with the same id already exists, updating its data and moving it to the top of the list.

Chat update and save logic improvements:

  • Modified the chat update logic in Chat.tsx to check for existing conversation IDs in chat history before adding new conversations, and to always set the selected conversation ID after a successful update.
  • Changed all calls to saveToDB in Chat.tsx to be awaited, ensuring that chat data is reliably saved before proceeding, which improves data consistency during async operations. [1] [2] [3]

Code cleanup:

  • Removed the unused isWorkShopDeployment import and related conditional logic in Chat.tsx, simplifying the parsing of chart responses. [1] [2] ] I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Tejasri-Microsoft Tejasri-Microsoft changed the title [Agentic Apps] - Two chat history titles for current chat fix: [Agentic Apps] - Two chat history titles for current chat Mar 19, 2026
@microsoft-github-policy-service

@Tejasri-Microsoft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent duplicate conversation entries in chat history and ensure conversation updates (title/id selection + persistence) behave consistently across async updates.

Changes:

  • Added conversation deduplication by id in chatHistorySlice and applied it during bulk adds and history fetch/pagination.
  • Updated the “save/update conversation” flow in Chat.tsx to use the final conversation id, avoid creating duplicates, and reliably await persistence.
  • Removed workshop-mode-specific chart parsing branch and cleaned up related imports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/App/src/store/chatHistorySlice.ts Introduces dedupeConversationsById and uses it in reducers and fetch-history fulfillment to prevent duplicates.
src/App/src/components/Chat/Chat.tsx Adjusts save/update logic to pick the correct conversation id, avoid duplicate history entries, and await DB persistence; removes workshop-mode parsing branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants