Skip to content

fix: pin 5 unpinned action(s),extract 5 unsafe expression(s) to env vars #46518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dagecko wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −8
Open

fix: pin 5 unpinned action(s),extract 5 unsafe expression(s) to env vars #46518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/automatic-issue-deduplication.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Run Deduplicate Action
uses: pelikhan/action-genai-issue-dedup@v0
uses: pelikhan/action-genai-issue-dedup@bdb3b5d9451c1090ffcdf123d7447a5e7c7a2528 # v0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
label_as_duplicate: true
2 changes: 1 addition & 1 deletion .github/workflows/manual-batch-issue-deduplication.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: actions/checkout@v6

- name: Run GenAI Issue Deduplicator
uses: pelikhan/action-genai-issue-dedup@v0
uses: pelikhan/action-genai-issue-dedup@bdb3b5d9451c1090ffcdf123d7447a5e7c7a2528 # v0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
github_issue: ${{ matrix.issue }}
Expand Down
20 changes: 14 additions & 6 deletions .github/workflows/msstore-submissions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
export $(echo 'anypass_just_to_unlock' | gnome-keyring-daemon --start --components=gpg,pkcs11,secrets,ssh)

- name: Log in to Azure
uses: azure/login@v2
uses: azure/login@a457da9ea143d694b1b9c7c869ebb04ebe844ef5 # v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
Expand All @@ -44,10 +44,10 @@ jobs:
with:
dotnet-version: '9.0.x'

- uses: microsoft/setup-msstore-cli@v1
- uses: microsoft/setup-msstore-cli@3b2ec9136230357ce9abc02b9d056626fb248d3f # v1

- name: Fetch Store Credential
uses: azure/cli@v2
uses: azure/cli@9f7ce6f37c31b777ec6c6b6d1dfe7db79f497956 # v2
with:
azcliversion: latest
inlineScript: |-
Expand All @@ -56,11 +56,15 @@ jobs:

- name: Configure Store Credentials
run: |-
msstore reconfigure -cfp cert.pfx -c ${{ secrets.AZURE_CLIENT_ID }} -t ${{ secrets.AZURE_TENANT_ID }} -s ${{ secrets.SELLER_ID }}
Copy link
Member

@DHowett DHowett Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is, frankly, BS. The threat model here is that, what, a repository admin compromises their own repository using the highly convoluted mechanism of changing their repo Secrets, rather than just pushing whatever they want anywhere at any time?

msstore reconfigure -cfp cert.pfx -c ${AZURE_CLIENT_ID} -t ${AZURE_TENANT_ID} -s ${SELLER_ID}

env:
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
SELLER_ID: ${{ secrets.SELLER_ID }}
- name: Update draft submission
run: |-
msstore submission update ${{ secrets.PRODUCT_ID }} '{
msstore submission update ${PRODUCT_ID} '{
"packages":[
{
"packageUrl":"${{ steps.releaseVars.outputs.powerToysInstallerX64Url }}",
Expand All @@ -79,10 +83,14 @@ jobs:
]
}'

env:
PRODUCT_ID: ${{ secrets.PRODUCT_ID }}
- name: Publish Submission
run: |-
msstore submission publish ${{ secrets.PRODUCT_ID }}
msstore submission publish ${PRODUCT_ID}

env:
PRODUCT_ID: ${{ secrets.PRODUCT_ID }}
- name: Clean up auth certificate
if: always()
run: |-
Expand Down
Loading