Skip to content

Use spaces instead of tabs and spaces#358

Merged
megastep merged 6 commits into
megastep:masterfrom
mattviasat:consistent-whitespace
Apr 19, 2026
Merged

Use spaces instead of tabs and spaces#358
megastep merged 6 commits into
megastep:masterfrom
mattviasat:consistent-whitespace

Conversation

@mattviasat
Copy link
Copy Markdown
Contributor

@mattviasat mattviasat commented Apr 17, 2026

I noticed that both spaces and tabs are used. This PR replaces the tabs with spaces for consistency.

I also added a .git-blame-ignore-revs so that my changes do not appear in the git blame. See https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view

You can see the blames do not include the change
https://github.com/mattviasat/makeself/blame/consistent-whitespace/makeself-header.sh
https://github.com/mattviasat/makeself/blame/consistent-whitespace/makeself.sh

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on whitespace normalization across makeself-header.sh and makeself.sh, replacing literal tabs with spaces. A functional regression was identified in makeself.sh where a literal tab in a sed command used for parsing cksum output was incorrectly replaced with spaces; a more robust awk-based solution was suggested to resolve this issue.

Comment thread makeself.sh Outdated
@megastep megastep self-assigned this Apr 19, 2026
Copy link
Copy Markdown
Owner

@megastep megastep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@megastep megastep merged commit 9d3a0a8 into megastep:master Apr 19, 2026
12 checks passed
@mattviasat mattviasat deleted the consistent-whitespace branch April 20, 2026 14:52
@mattviasat
Copy link
Copy Markdown
Contributor Author

@megastep Looks like the .git-blame-ignore-revs didn't work, see https://github.com/megastep/makeself/blame/master/makeself-header.sh
When you merge, the commit shas changed. Probably because it came from a fork.
So the commits to ignore in the .git-blame-ignore-revs are
18141f674f3e0d8b30cba82af3c927b169066219
ba6e14e9d8113f227b18ddecf76fd95dfc089f14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants