You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on whitespace normalization across makeself-header.sh and makeself.sh, replacing literal tabs with spaces. A functional regression was identified in makeself.sh where a literal tab in a sed command used for parsing cksum output was incorrectly replaced with spaces; a more robust awk-based solution was suggested to resolve this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that both spaces and tabs are used. This PR replaces the tabs with spaces for consistency.
I also added a
.git-blame-ignore-revsso that my changes do not appear in the git blame. See https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-viewYou can see the blames do not include the change
https://github.com/mattviasat/makeself/blame/consistent-whitespace/makeself-header.sh
https://github.com/mattviasat/makeself/blame/consistent-whitespace/makeself.sh