Changes example in CSS invert() to use appropriate classes.#43581
Open
Changes example in CSS invert() to use appropriate classes.#43581
Conversation
…rt use the svg. - The item labelled as css now uses the `invert` class - The item labelled as SVG now uses the `svginvert` class that was previously used by the css item instead of a direct SVG, more in line with the explanation.
Refactor HTML for image display in invert filter example.
…dex.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
Preview URLs (1 page) |
chrisdavidmills
requested changes
Mar 26, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
Hi @elooly10. What you are proposing to fix makes sense, but you've gone too far and broken the SVG equivalent — see the comment below.
| <td> | ||
| <img | ||
| class="svgFilter" | ||
| class="filter" |
Contributor
There was a problem hiding this comment.
This is the only change that is needed to make the fix that you've proposed. The other changes below have broken the SVG equivalent version — it no longer displays properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies the css invert to the item in the example labelled
invert() filterinstead of the SVG invert for theSVG filter equivalent, and fixes the SVG filter equivalent with a class as the document's text explains rather than as an inline SVG.Motivation
The changes keep the content accurate and make the playground more useable.