Skip to content

Check the user ID in the embedded device keys#6553

Merged
poljar merged 2 commits into
mainfrom
poljar/better-device-keys-check
May 8, 2026
Merged

Check the user ID in the embedded device keys#6553
poljar merged 2 commits into
mainfrom
poljar/better-device-keys-check

Conversation

@poljar
Copy link
Copy Markdown
Contributor

@poljar poljar commented May 8, 2026

Adds a missing check for the user ID in the embedded device keys.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

@poljar poljar requested review from a team as code owners May 8, 2026 11:27
@poljar poljar requested review from andybalaam and removed request for a team May 8, 2026 11:27
@poljar poljar force-pushed the poljar/better-device-keys-check branch from d9fbabf to b8bc629 Compare May 8, 2026 11:28
@poljar poljar requested a review from gewitternacht May 8, 2026 11:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (777ce05) to head (b8bc629).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-crypto/src/olm/account.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6553      +/-   ##
==========================================
- Coverage   89.92%   89.92%   -0.01%     
==========================================
  Files         381      381              
  Lines      106860   106865       +5     
  Branches   106860   106865       +5     
==========================================
+ Hits        96095    96098       +3     
- Misses       7108     7114       +6     
+ Partials     3657     3653       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar enabled auto-merge (rebase) May 8, 2026 11:43
@poljar poljar merged commit f4b2794 into main May 8, 2026
53 checks passed
@poljar poljar deleted the poljar/better-device-keys-check branch May 8, 2026 11:43
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing poljar/better-device-keys-check (b8bc629) with main (777ce05)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants