Skip to content

Harden our CI workflows and add a zizmor workflow#6460

Merged
poljar merged 3 commits into
mainfrom
poljar/zizmor
Apr 20, 2026
Merged

Harden our CI workflows and add a zizmor workflow#6460
poljar merged 3 commits into
mainfrom
poljar/zizmor

Conversation

@poljar
Copy link
Copy Markdown
Contributor

@poljar poljar commented Apr 17, 2026

No description provided.

@poljar poljar requested a review from a team as a code owner April 17, 2026 11:41
@poljar poljar requested review from Hywan and removed request for a team April 17, 2026 11:41
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread .github/workflows/coverage.yml Fixed
Comment thread .github/workflows/coverage.yml Fixed
Comment thread .github/workflows/bindings_ci.yml Fixed
Comment thread .github/workflows/bindings_ci.yml Fixed
Comment thread .github/workflows/bindings_ci.yml Fixed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/coverage.yml Fixed
Comment thread .github/workflows/documentation.yml Dismissed
Comment thread .github/workflows/xtask.yml Fixed
Comment thread .github/workflows/bindings_ci.yml Dismissed
Comment thread .github/workflows/bindings_ci.yml Dismissed
Comment thread .github/workflows/bindings_ci.yml Dismissed
Comment thread .github/workflows/bindings_ci.yml Dismissed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/coverage.yml Dismissed
Comment thread .github/workflows/xtask.yml Dismissed
Comment thread .github/workflows/coverage.yml Fixed
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 17, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing poljar/zizmor (892474a) with main (1e74c48)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (1e74c48) to head (892474a).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6460   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         379      379           
  Lines      104699   104699           
  Branches   104699   104699           
=======================================
+ Hits        94114    94120    +6     
  Misses       6983     6983           
+ Partials     3602     3596    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar
Copy link
Copy Markdown
Contributor Author

poljar commented Apr 17, 2026

The rust-toolchain action warning is a bit misleading. More details here: zizmorcore/zizmor#1817.

As such I'll dismiss the warning.

@poljar poljar merged commit c962a52 into main Apr 20, 2026
54 checks passed
@poljar poljar deleted the poljar/zizmor branch April 20, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants