feat(base): Explicitly handle the CrossProcessLockKind::Dirty case in MediaStore#5855
Merged
Hywan merged 2 commits intomatrix-org:mainfrom Nov 11, 2025
Merged
Conversation
671d243 to
70be27b
Compare
stefanceriu
approved these changes
Nov 11, 2025
…in `MediaStore`. This patch replaces the `into_guard()` call by a `match` over `CrossProcessLockKind` so that the `Dirty` case is explicitly handled. The mid-term idea is to remove the `into_guard()` method because it is “dangerous” as it hides the `Dirty` case.
70be27b to
e32dfb4
Compare
13 tasks
CodSpeed Performance ReportMerging #5855 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5855 +/- ##
==========================================
- Coverage 88.60% 88.59% -0.02%
==========================================
Files 362 362
Lines 102303 102307 +4
Branches 102303 102307 +4
==========================================
- Hits 90643 90635 -8
- Misses 7440 7453 +13
+ Partials 4220 4219 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces the
into_guard()call by amatchoverCrossProcessLockKindso that theDirtycase is explicitly handled.The mid-term idea is to remove the
into_guard()method because it is “dangerous” as it hides theDirtycase.