Don't do an authenticated /versions request in the RoomListService builder#5853
Merged
Don't do an authenticated /versions request in the RoomListService builder#5853
/versions request in the RoomListService builder#5853Conversation
poljar
commented
Nov 11, 2025
57f4709 to
f776b32
Compare
Hywan
approved these changes
Nov 11, 2025
f776b32 to
4ed853a
Compare
4ed853a to
8347b3a
Compare
CodSpeed Performance ReportMerging #5853 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5853 +/- ##
==========================================
- Coverage 88.60% 88.59% -0.01%
==========================================
Files 361 361
Lines 102294 102311 +17
Branches 102294 102311 +17
==========================================
+ Hits 90640 90646 +6
- Misses 7433 7443 +10
- Partials 4221 4222 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5845
This rather avoids the issue instead of fixing it. As the
/versionscall in theRoomListServiceis only used to figure out if a certain feature the user has enabled should actually be enabled and this is a release blocker for EX, I deemed that it's fine to avoid tackling the problem that/versionscalls can't do token refresh.