Skip to content

Don't do an authenticated /versions request in the RoomListService builder#5853

Merged
poljar merged 2 commits intomainfrom
poljar/fix-versions-roomlist-service-builder
Nov 11, 2025
Merged

Don't do an authenticated /versions request in the RoomListService builder#5853
poljar merged 2 commits intomainfrom
poljar/fix-versions-roomlist-service-builder

Conversation

@poljar
Copy link
Copy Markdown
Contributor

@poljar poljar commented Nov 11, 2025

This closes #5845

This rather avoids the issue instead of fixing it. As the /versions call in the RoomListService is only used to figure out if a certain feature the user has enabled should actually be enabled and this is a release blocker for EX, I deemed that it's fine to avoid tackling the problem that /versions calls can't do token refresh.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner November 11, 2025 12:52
@poljar poljar requested review from Hywan and removed request for a team November 11, 2025 12:52
Comment thread crates/matrix-sdk-ui/tests/integration/room_list_service.rs
@poljar poljar force-pushed the poljar/fix-versions-roomlist-service-builder branch from 57f4709 to f776b32 Compare November 11, 2025 12:56
Comment thread crates/matrix-sdk-ui/src/room_list_service/mod.rs
@poljar poljar force-pushed the poljar/fix-versions-roomlist-service-builder branch from f776b32 to 4ed853a Compare November 11, 2025 13:01
@poljar poljar enabled auto-merge (rebase) November 11, 2025 13:02
@poljar poljar disabled auto-merge November 11, 2025 13:04
@poljar poljar force-pushed the poljar/fix-versions-roomlist-service-builder branch from 4ed853a to 8347b3a Compare November 11, 2025 13:07
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 11, 2025

CodSpeed Performance Report

Merging #5853 will not alter performance

Comparing poljar/fix-versions-roomlist-service-builder (8347b3a) with main (e79f832)

Summary

✅ 50 untouched

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.59%. Comparing base (f9584f5) to head (8347b3a).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/client/mod.rs 45.45% 5 Missing and 1 partial ⚠️
crates/matrix-sdk-ui/src/room_list_service/mod.rs 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5853      +/-   ##
==========================================
- Coverage   88.60%   88.59%   -0.01%     
==========================================
  Files         361      361              
  Lines      102294   102311      +17     
  Branches   102294   102311      +17     
==========================================
+ Hits        90640    90646       +6     
- Misses       7433     7443      +10     
- Partials     4221     4222       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit f61ba4f into main Nov 11, 2025
81 of 82 checks passed
@poljar poljar deleted the poljar/fix-versions-roomlist-service-builder branch November 11, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building the SyncService can fail if a /versions request fails

2 participants