fix(ui): Undo an optimisation to start at SettingUp#5852
Merged
Hywan merged 1 commit intomatrix-org:mainfrom Nov 11, 2025
Merged
fix(ui): Undo an optimisation to start at SettingUp#5852Hywan merged 1 commit intomatrix-org:mainfrom
SettingUp#5852Hywan merged 1 commit intomatrix-org:mainfrom
Conversation
This patch undo an optimisation that was initialising the `RoomListService` at the `SettingUp` state if a `pos` value was recovered successfully (see bbf9bf2). The problem is that it starts with a range of 0..99 instead of 0..19, which can slow things done in particular cases. Whilst a good idea on paper, it's not in practise. So let's continue to recover the `pos`, but let's keep starting at the `Init` state.
Hywan
requested review from
a team,
andybalaam,
pixlwave and
stefanceriu
and removed request for
a team and
andybalaam
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5852 +/- ##
=======================================
Coverage 88.59% 88.60%
=======================================
Files 361 361
Lines 102287 102280 -7
Branches 102287 102280 -7
=======================================
- Hits 90624 90621 -3
+ Misses 7444 7440 -4
Partials 4219 4219 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5852 will not alter performanceComparing Summary
|
Member
|
Related: element-hq/element-x-ios#4728 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch undo an optimisation that was initialising the
RoomListServiceat theSettingUpstate if aposvalue was recovered successfully (see bbf9bf2 from #4741). The problem is that it starts with a range of 0..99 instead of 0..19, which can slow things done in particular cases. Whilst a good idea on paper, it's not in practise. So let's continue to recover thepos, but let's keep starting at theInitstate.