fix(base): Remove a panic in a log#5851
Merged
Hywan merged 1 commit intomatrix-org:mainfrom Nov 11, 2025
Merged
Conversation
We must not panic if the event has no event ID.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5851 +/- ##
=======================================
Coverage 88.59% 88.60%
=======================================
Files 361 361
Lines 102287 102287
Branches 102287 102287
=======================================
+ Hits 90624 90632 +8
+ Misses 7444 7435 -9
- Partials 4219 4220 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5851 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must not panic if the event has no event ID.