Skip to content

fix(base): Remove a panic in a log#5851

Merged
Hywan merged 1 commit intomatrix-org:mainfrom
Hywan:fix-base-panic-in-log
Nov 11, 2025
Merged

fix(base): Remove a panic in a log#5851
Hywan merged 1 commit intomatrix-org:mainfrom
Hywan:fix-base-panic-in-log

Conversation

@Hywan
Copy link
Copy Markdown
Member

@Hywan Hywan commented Nov 11, 2025

We must not panic if the event has no event ID.

We must not panic if the event has no event ID.
@Hywan Hywan requested a review from a team as a code owner November 11, 2025 10:01
@Hywan Hywan requested review from stefanceriu and removed request for a team November 11, 2025 10:01
Copy link
Copy Markdown
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.60%. Comparing base (fff270d) to head (a8241c6).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...k-base/src/response_processors/room/msc4186/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5851   +/-   ##
=======================================
  Coverage   88.59%   88.60%           
=======================================
  Files         361      361           
  Lines      102287   102287           
  Branches   102287   102287           
=======================================
+ Hits        90624    90632    +8     
+ Misses       7444     7435    -9     
- Partials     4219     4220    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit 46d05d8 into matrix-org:main Nov 11, 2025
52 checks passed
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 11, 2025

CodSpeed Performance Report

Merging #5851 will not alter performance

Comparing Hywan:fix-base-panic-in-log (a8241c6) with main (fff270d)

Summary

✅ 50 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants