Skip to content

refactor(oauth): remove superfluous join in QR login tests#5850

Merged
poljar merged 1 commit intomatrix-org:mainfrom
Johennes:johannes/no-join
Nov 11, 2025
Merged

refactor(oauth): remove superfluous join in QR login tests#5850
poljar merged 1 commit intomatrix-org:mainfrom
Johennes:johannes/no-join

Conversation

@Johennes
Copy link
Copy Markdown
Contributor

@Johennes Johennes commented Nov 11, 2025

As discussed in #5840 (comment), the joins are not needed because two of the awaited tasks were already spawned.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes marked this pull request as ready for review November 11, 2025 07:52
@Johennes Johennes requested a review from a team as a code owner November 11, 2025 07:52
@Johennes Johennes requested review from andybalaam and removed request for a team November 11, 2025 07:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.60%. Comparing base (10ff5d0) to head (2ec6e61).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5850      +/-   ##
==========================================
- Coverage   88.60%   88.60%   -0.01%     
==========================================
  Files         361      361              
  Lines      102294   102287       -7     
  Branches   102294   102287       -7     
==========================================
- Hits        90637    90628       -9     
- Misses       7438     7439       +1     
- Partials     4219     4220       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit a50ecb5 into matrix-org:main Nov 11, 2025
58 of 59 checks passed
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 11, 2025

CodSpeed Performance Report

Merging #5850 will not alter performance

Comparing Johennes:johannes/no-join (2ec6e61) with main (10ff5d0)

Summary

✅ 50 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants