Gateway SUP integration#180
Conversation
|
@julienduquesnay-se - I won't be able to review this until next week. |
|
@julienduquesnay-se - would you mind updating your branch? It's showing changes related to the helm PR as changes in your branch |
@phil-abb, I was trying to merge the latest changes from the "pre-draft" branch, and it looks like it grabbed your latest commit. I might need help to clean that up. |
Signed-off-by: Julien Duquesnay <julien.duquesnay@se.com>
Signed-off-by: Julien Duquesnay <julien.duquesnay@se.com>
Signed-off-by: Julien Duquesnay <julien.duquesnay@se.com>
I rebased via the GitHub PR UI, and it looks ok now. |
There was a problem hiding this comment.
This file should not be added to this repo. It should be added to the General Website Content repo
The specification repo should only contain the files related directly to the specification. There is an open PR to delete the other files from this repo, but it's still in draft state (@ajcraig)
| | message | string | Y | Associated error message that provides further details to the WFM about the error that was encountered. | | ||
|
|
||
| > Note: Error codes and messages are implementation-specific. | ||
| When the error is generated by a see-thru gateway, the source attribute of the error structure MUST be set to the gateway device id, with its full hierachy if applicable. |
There was a problem hiding this comment.
It might be good to link to the location where th types of gateways is explained.
| > Note: Most error codes and messages are implementation-specific. | ||
|
|
||
| > Note: the purpose of the `source` attribute is to avoid collision between reserved error codes and implementation-specific error codes. |
There was a problem hiding this comment.
Can these two notes be combined?
| | 101 | Unknown child device ID | Id of the gateway | The gateway cannot identify the child device with the given ID. | | ||
| | 102 | Child device unreachable | Id of the gateway | The gateway cannot establish a connection with the child device. | | ||
|
|
||
| When the error used is a reserved code for gateway-generated error, the `source` attribute MUST be set to the id of the gateway, with its full hierachy if applicable. |
There was a problem hiding this comment.
| When the error used is a reserved code for gateway-generated error, the `source` attribute MUST be set to the id of the gateway, with its full hierachy if applicable. | |
| When the error used is a reserved code for a gateway-generated error, the `source` attribute MUST be set to the id of the gateway, with its full hierachy if applicable. |
| DeviceId: | ||
| # format: "{id}[/{id}[/{id}...]]" | ||
| # Top-level id is required and must include only Unreserved Characters as specified in RFC3986. | ||
| # Subsequent ids are optional, but if present must include only Unreserved Characters as specified in RFC3986. |
There was a problem hiding this comment.
| # Subsequent ids are optional, but if present must include only Unreserved Characters as specified in RFC3986. | |
| # Subsequent ids are optional, but if present must include only unreserved characters as specified in RFC3986. |
| pattern: '^[A-Za-z0-9._~-]+(\/[A-Za-z0-9._~-]+)*$' | ||
| DeviceId_with_asterisk: | ||
| # format: "{id}[/{id}[/{id}...]/*]" | ||
| # Top-level id is required and must include only Unreserved Characters as specified in RFC3986. |
There was a problem hiding this comment.
| # Top-level id is required and must include only Unreserved Characters as specified in RFC3986. | |
| # Top-level id is required and must include only unreserved characters as specified in RFC3986. |
| DeviceId: | ||
| # format: "{id}[/{id}[/{id}...]]" | ||
| # Top-level id is required and must include only Unreserved Characters as specified in RFC3986. | ||
| # Subsequent ids are optional, but if present must include only Unreserved Characters as specified in RFC3986. |
There was a problem hiding this comment.
Is there a better way to phrase this? They are not really optional because you have to use them to provide the information for child devices.
| DeviceId_with_asterisk: | ||
| # format: "{id}[/{id}[/{id}...]/*]" | ||
| # Top-level id is required and must include only Unreserved Characters as specified in RFC3986. | ||
| # Subsequent ids are optional, but if present must include only Unreserved Characters as specified in RFC3986. |
| - concepts/workload-fleet-managers/workload-deployment.md | ||
| - Edge Compute Devices: | ||
| - concepts/edge-compute-devices/devices.md | ||
| - Gateways: |
There was a problem hiding this comment.
Need to check on this with the new combined website layout. I'm not sure how we add to the navigation now. I'm not sure if this file is used anymore.
@ajcraig do you know?
2 participants
Description
Specification update related to the Gateway SUP. Add support of gateway service.
Issues Addressed
#137
Change Type
Please select the relevant options:
Checklist