Skip to content

docs(md): fixes onboarding seq diagram#178

Merged
singhmj-1 merged 2 commits into
pre-draftfrom
docs/133-fix-onboarding-seq-diag
May 18, 2026
Merged

docs(md): fixes onboarding seq diagram#178
singhmj-1 merged 2 commits into
pre-draftfrom
docs/133-fix-onboarding-seq-diag

Conversation

@singhmj-1
Copy link
Copy Markdown
Contributor

@singhmj-1 singhmj-1 commented May 12, 2026

Description

Fixes an incorrect field name i.e. public_certificate in device onboarding sequence diagram in the doc file.

Issues Addressed

Closes #133

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)
  • Content edits (change that edits existing content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

The diagram cited incorrect field name, `public_certificate`, during onboarding.
The actual field is just `certificate`.

Closes #133

Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
@singhmj-1 singhmj-1 self-assigned this May 12, 2026
@singhmj-1 singhmj-1 marked this pull request as ready for review May 13, 2026 07:12
@singhmj-1 singhmj-1 requested a review from a team as a code owner May 13, 2026 07:12
@singhmj-1 singhmj-1 requested review from ajcraig, matlec and phil-abb May 13, 2026 07:13
Co-authored-by: Philip Presson <philip.presson@us.abb.com>
Signed-off-by: Manjinder <manjinder.b.singh@capgemini.com>
@singhmj-1 singhmj-1 requested a review from phil-abb May 14, 2026 17:52
@ajcraig ajcraig removed their request for review May 15, 2026 14:20
Copy link
Copy Markdown
Contributor

@ajcraig ajcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ensure though we get a review from @matlec as he raised the issue.

Copy link
Copy Markdown
Contributor

@matlec matlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@singhmj-1 singhmj-1 merged commit dd70b9c into pre-draft May 18, 2026
12 checks passed
@singhmj-1 singhmj-1 deleted the docs/133-fix-onboarding-seq-diag branch May 18, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent certificate field name in WFM Client Onboarding spec

4 participants