Fix status shown for combined instrumentation jobs#223
Open
AlexJones0 wants to merge 1 commit into
Open
Conversation
An accidental omission of the intended `omit_status=True` keyword argument meant that for visualizations of the longest tests, where many jobs are combined into a single bar (for performance reasons), the status of the shortest such job was always being reported, instead of not reporting any status like was intended (since there could be variation amongst the combined jobs). Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HTML instrumentation report, the graph showing the longest tests (where each tests is many different jobs) had an issue where, for combined job bars (rendered to reduce the number of bars being stored/shown on lower render profiles for performance reasons), the status of the first/shortest job would be reported in the metadata of the tooltip shown on hovering over the bar.
This was instead intended to not show a status at all, since there might be variation in the outcomes of these combined jobs. Fix this by adding the omitted argument.