[CI Testing Only] PR #1187 AMD verification: debug layer OFF#1194
Draft
alsepkow wants to merge 7 commits into
Draft
[CI Testing Only] PR #1187 AMD verification: debug layer OFF#1194alsepkow wants to merge 7 commits into
alsepkow wants to merge 7 commits into
Conversation
Both AMD and NVIDIA DirectX configurations have been stable and have higher pass rates than the existing Tier 1 Intel target. Promote them to Tier 1 so they run on every PR. Qualcomm and the Vulkan IHV configurations remain experimental and continue to require the 'test-all' label. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match the tier change in docs/CI.md and pr-matrix.yaml so the README status table reflects that these targets now run on every PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Per Bob's review feedback, switch from listing AMD/NVIDIA D3D12 combinations via 'include' to a cross-product with 'exclude' for the AMD/NVIDIA Vulkan combinations. As future targets get promoted out of experimental, we can simply remove exclusions rather than adding inclusions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Apply the same cross-product + exclude pattern to the experimental Exec-Tests-Extra job for consistency. As targets are promoted out of experimental, exclusions can be added here in lockstep with their removal from the Tier 1 Exec-Tests-Windows job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 1eec3eb. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This change is for the draft AMD-testing PR only and should NOT be merged.
Strips the matrix down to only windows-amd x {check-hlsl-d3d12, check-hlsl-clang-d3d12}
so we can quickly iterate on AMD D3D12 stability investigation without spending
CI on Intel/NVIDIA/MacOS/WARP/Vulkan jobs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds -DOFFLOADTEST_ENABLE_DEBUG=Off to test whether the AMD amdxc64.dll PSO compilation crashes/failures still reproduce when the D3D12 debug layer (D3D12SDKLayers.dll) is not present in the call chain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CI testing only — do not merge]
Third variant of PR #1187 verification, testing the D3D12 debug layer as a contributing factor to the AMD
amdxc64.dllPSO compilation crashes.What this changes
Adds
-DOFFLOADTEST_ENABLE_DEBUG=Offto the AMD CI builds. This setsOFFLOADTEST_ENABLE_DEBUG=OFFin CMake, which causestest/lit.cfg.pyto omit the-debug-layerflag when invokingoffloader.exe. So the offloader runs withoutD3D12SDKLayers.dllin the call chain.Why
In the crashes observed in PRs #1189 (RelWithDebInfo) and #1190 (Debug), the call stack shows
D3D12SDKLayers.dlldirectly above the AMD frames:We want to know:
amdxc64.dll)amdxc64.dllPSO compilationCompanion PRs
Branch
alsepkow/offload-test-suite:pr-1187-testing-no-debug-layerpromote-dx-targetsbranch-DOFFLOADTEST_ENABLE_DEBUG=Offadded toLLVM-ExtraCMakeArgs