Add asfloat, asuint and asint matrices test#1186
Open
joaosaffran wants to merge 5 commits into
Open
Conversation
joaosaffran
added
the
test-all
Icohedron
requested changes
May 13, 2026
Contributor
Icohedron
left a comment
Icohedron
left a comment
There was a problem hiding this comment.
Add tests involving constant literals in the shaders
Icohedron
approved these changes
May 14, 2026
kmpeng
reviewed
May 15, 2026
| RWStructuredBuffer<float4> Out2 : register(u5); | ||
|
|
||
| [numthreads(1,1,1)] | ||
| void main() { |
Contributor
There was a problem hiding this comment.
Can we get 1 dimensional matrix tests? The requirements say to test columns > row, row > columns, 1 dimensional, and the max size
| RWStructuredBuffer<int4> Out3 : register(u5); | ||
|
|
||
| [numthreads(1,1,1)] | ||
| void main() { |
Contributor
There was a problem hiding this comment.
Same as above - 1 dimensional matrix tests
| RWStructuredBuffer<uint4> Out2 : register(u5); | ||
|
|
||
| [numthreads(1,1,1)] | ||
| void main() { |
Contributor
There was a problem hiding this comment.
Same as above - 1 dimensional matrix tests
| RWStructuredBuffer<uint4> Highs : register(u2); | ||
|
|
||
| [numthreads(1,1,1)] | ||
| void main() { |
Contributor
There was a problem hiding this comment.
Same as above - 1 dimensional matrix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds matrices versions for asfloat, asuint and asint intrinsics tests.
Fix: llvm/llvm-project#184471, llvm/llvm-project#184472 and llvm/llvm-project#184474
Assisted by: Claude Opus 4.6