Improve vulkan pipeline creation, better spec const parsing and error handling.#1176
Merged
manon-traverse merged 3 commits intoMay 21, 2026
Merged
Conversation
manon-traverse
force-pushed
the
improve-pipeline-creation
branch
from
7dcfca0 to
1ce7750
Compare
MarijnS95
approved these changes
May 21, 2026
Comment on lines
+1381
to
+1382
| auto ShaderModuleCleanUp = llvm::scope_exit( | ||
| [&] { vkDestroyShaderModule(Device, CSModule, nullptr); }); |
Collaborator
There was a problem hiding this comment.
Retaining your own comment about destroying these even when the PSO is successfully created would be nice.
Suggested change
| auto ShaderModuleCleanUp = llvm::scope_exit( | |
| [&] { vkDestroyShaderModule(Device, CSModule, nullptr); }); | |
| // No longer need shader modules after pipeline compilation. | |
| auto ShaderModuleCleanUp = llvm::scope_exit( | |
| [&] { vkDestroyShaderModule(Device, CSModule, nullptr); }); |
Contributor
Author
|
Merging this before CI finished, because only a comment was added since last CI completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some fixes that I made while implementing mesh shader pipeline creation, which also apply to the other pipeline creation functions. Putting this in a separate PR to keep the work in smaller incremental changes.