docs: clarify dimension interaction with distinct_keys#654
Merged
Conversation
Contributor
🤖 Documentation Bot✅ All checks passed! No issues found. |
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Clarified the interaction of selected dimensions with distinct_keys in metrics. Updated examples to improve understanding of deduplication behavior.
Contributor
🤖 Documentation Bot✅ All checks passed! No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents how selected dimensions interact with
distinct_keysfor thesum_distinctandaverage_distinctmetric types, reflecting the updated semantics where deduplication is always performed globally ondistinct_keysregardless of which dimensions are selected (matching Looker's behavior).Changes
distinct_keys" subsection undersum_distinctinreferences/metrics.mdx, explaining:distinct_keysgroup the metric (one deduplicated value per group).distinct_keysdo not affect dedup; the global deduplicated value is repeated across rows.distinct_keysif you want a per-group total.average_distinctsection.Context
Source PR updates
sum_distinct/average_distinctto deduplicate globally ondistinct_keysrather than partitioning by the user-selected dimensions, which previously produced per-group sums and obscured the global deduplicated total when the selected dimension was orthogonal to thedistinct_keysgrain.