Fixing linking fmt & improved visitor patterns#28
Merged
KaruroChori merged 12 commits intomasterfrom Jul 7, 2025
Merged
Conversation
…ing TreeRaw iterator. Linking regression emerged, to be investigated and fixed.
Contributor
Author
|
It looks like something broke on my system for whatever strange and obscure reason? I get errors like this when replicating the same build of CI. |
…fmt, since that library is not linked in the final application, some symbols being generated by libvs-xml inline in the headers are not part of the final optimized blob, and code will complain it cannot be found.
Contributor
Author
|
So, the issue was found. In
This is a huge pain to handle, and makes the build process much more fragile than what I would like. But some solution will be found at some point. |
…o keep the basic interface more embedded-friendly. Also it was recursive which is not good.
… will also allow a template version to be exposed (likely speedup to implement serialiation and no memory allocation due to lambda context)
fmt & improved visitor patterns
…the new one. New print functions to match added capabilities.
…sitor patterns. Added `[[nodiscard]]` around to fix interfaces.
…ch inherited from an early version. Dependencies have now been better isolated in compile units to avoid leaking to downstream code. The interface is basically the same as the earlier commit, but it fixes all issues with linking fmt to downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29 and #30
This last commit has regressions in linking which I am not able to fully isolate.
Running in CI might help to figure out what is going on.it did, issue found out, resolution pending.That being said I will make use of this PR to fix/improve the visitor interface, so that the new
print2serialization is not needing memory allocations for the lambda capture contexts.